Closed Bug 808865 Opened 7 years ago Closed 7 years ago

[WebAPI] WebSMS: Develop a test to verify getNumberOfMessagesForText

Categories

(Core :: DOM: Device Interfaces, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19
Tracking Status
firefox18 --- fixed
firefox19 --- fixed

People

(Reporter: rwood, Assigned: rwood)

Details

Attachments

(1 file, 1 obsolete file)

Develop a marionette test (to run on the b2g emulator) to verify MozSmsManager.getNumberOfMessagesForText.
Attached patch Patch for 808865 (obsolete) — Splinter Review
Attachment #680147 - Flags: review?(jgriffin)
Comment on attachment 680147 [details] [diff] [review]
Patch for 808865

Review of attachment 680147 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/sms/tests/marionette/test_number_of_messages.js
@@ +41,5 @@
> +  for (var x = 1; x <= numChars; x++) {
> +    string += char;
> +  }
> +  return string;
> +}

A more compact way to do this is JS is:
string = new Array(numChars + 1).join(char);
Attachment #680147 - Flags: review?(jgriffin) → review+
Ahh yes, that's a better way, thanks Jonathan. I updated the patch anyway as it was a quick change.
Attachment #680147 - Attachment is obsolete: true
Attachment #681037 - Flags: review?(jgriffin)
Attachment #681037 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/f6511d0a33eb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.