[BB][Browser] Apply building blocks [input_areas]

VERIFIED FIXED

Status

Firefox OS
Gaia::Browser
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: ivanovpavel, Assigned: ivanovpavel)

Tracking

(Depends on: 1 bug)

unspecified
x86
Mac OS X

Firefox Tracking Flags

(b2g18 verified)

Details

(Whiteboard: BerlinWW, uxbranch, landed in uxbranch, qa-verified)

Attachments

(2 attachments, 2 obsolete attachments)

Apply shared/input_areas.css on browser application.
Attachment #678605 - Flags: review?(ben)
Comment on attachment 678605 [details]
patch

Clearing review request because this patch is obsolete.
Attachment #678605 - Flags: review?(ben)
Attachment #678605 - Attachment is obsolete: true
Attachment #685136 - Flags: review?(ben)
We need this Bug #815074 to be landed for <input type="url">
Depends on: 815074
Comment on attachment 685136 [details]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: n/a
Testing completed (on m-c, etc.): nightly Unagi build + gaia master 
Risk to taking this patch (and alternatives if risky): small CSS change, low impact
String or UUID changes made by this patch: n/a
Attachment #685136 - Flags: review?(ben)
Attachment #685136 - Flags: review+
Attachment #685136 - Flags: approval-mozilla-aurora?
Attachment #685136 - Flags: approval-mozilla-aurora? → approval-gaia-master?(21)
Attachment #685136 - Attachment is obsolete: true
Attachment #685136 - Flags: approval-gaia-master?(21)
I move this patch to UX branch.
Attachment #685661 - Flags: review?(ben)
Attachment #685661 - Flags: review?(ben) → review+
Whiteboard: BerlinWW
Assignee: nobody → pivanov
Created attachment 700869 [details]
patch for Gaia repo

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
Attachment #700869 - Flags: approval-gaia-master?(21)

Comment 9

5 years ago
Landed in UX Branch https://github.com/gordonbrander/gaia/commit/82756b92e679bc354c5218a94285bace26c59191
Whiteboard: BerlinWW → BerlinWW, uxbranch, landed in uxbranch
Comment on attachment 700869 [details]
patch for Gaia repo

It will be part of the UX branch weekly PR. So let's remove the individual a? flag.
Attachment #700869 - Flags: approval-gaia-master?(21)
Sure. Thanks Vivien, sorry for the delay and for the flag.
The second part of the PR concerns me a little...
Changes on 'apps/browser/style/browser.css' are to remove input styling because we use now [BB][input_areas]
Yes, thank you.  It was late at night and I guess my brain was not thinking.

I saw the code in shared/style/input_areas.css ; I guess I expected to see the file added in the same PR under the commit ID.  The only thing I noticed was that the padding and the coloring is slightly different.  Marking for qa-verified.
Whiteboard: BerlinWW, uxbranch, landed in uxbranch → BerlinWW, uxbranch, landed in uxbranch, qa-verified
Master build : 2013-03-25-03-07-06
"mozilla-central" revision="bef19bca23f9"
"integration/gaia-central" revision="8c401e09a6a9"
"gecko.git"revision="bbaac6bbbf5084ef1a3e178ced676ea77db8b24b"
"gaia.git" revision="a1259a6c80629daa458428d6a96403841aaab0f0"

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/dec694d585e1
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
BuildID 20130325070203
Version 18.0
Unagi
Status: RESOLVED → VERIFIED
status-b2g18: --- → verified
You need to log in before you can comment on or make changes to this bug.