808894 - [BB][Browser] Apply building blocks [input_areas]

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Apply shared/input_areas.css on browser application.

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch

Comment 2

[Ben Francis [:benfrancis]]

Comment on attachment 678605 [details]
patch

Clearing review request because this patch is obsolete.

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We need this Bug #815074 to be landed for <input type="url">

Comment 5

[Ben Francis [:benfrancis]]

Comment on attachment 685136 [details]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: n/a
Testing completed (on m-c, etc.): nightly Unagi build + gaia master 
Risk to taking this patch (and alternatives if risky): small CSS change, low impact
String or UUID changes made by this patch: n/a

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I move this patch to UX branch.

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 9

[Sam Joch [:samjoch]]

Landed in UX Branch https://github.com/gordonbrander/gaia/commit/82756b92e679bc354c5218a94285bace26c59191

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 700869 [details]
patch for Gaia repo

It will be part of the UX branch weekly PR. So let's remove the individual a? flag.

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sure. Thanks Vivien, sorry for the delay and for the flag.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

The second part of the PR concerns me a little...

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Changes on 'apps/browser/style/browser.css' are to remove input styling because we use now [BB][input_areas]

Comment 14

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Yes, thank you.  It was late at night and I guess my brain was not thinking.

I saw the code in shared/style/input_areas.css ; I guess I expected to see the file added in the same PR under the commit ID.  The only thing I noticed was that the padding and the coloring is slightly different.  Marking for qa-verified.

Comment 15

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb

Comment 16

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Master build : 2013-03-25-03-07-06
"mozilla-central" revision="bef19bca23f9"
"integration/gaia-central" revision="8c401e09a6a9"
"gecko.git"revision="bbaac6bbbf5084ef1a3e178ced676ea77db8b24b"
"gaia.git" revision="a1259a6c80629daa458428d6a96403841aaab0f0"

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/dec694d585e1
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
BuildID 20130325070203
Version 18.0
Unagi