809031 - OOP <iframe> content disappear if placed below 147px inside the system

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Salvador de la Puente González [:salva]]

Attachment: Adds new application Processes with an animated iframe in the notification tray. You can see how below certain place, its content disappears.

Replication:
  Append a mozbrowser OOP <iframe> below 147px inside the system

Expected:
The content is displayed normally.

Currently:
The content disappears.

Comment 1

[Doug Turner (:dougt)]

Salvador,
  Could you explain why this bug should block the release of v.1 of B2G?

  Also, the content not rendering at all, or is the content in the iframe being unloaded?

Comment 2

[Salvador de la Puente González [:salva]]

(In reply to Doug Turner (:dougt) from comment #1)
> Salvador,
>   Could you explain why this bug should block the release of v.1 of B2G?

I don't know if it is blocking because we have no cases of placing an iframe in that position except for Cost Control. But there is a workaround using CSS' translate to properly place the iframe element.

>   Also, the content not rendering at all, or is the content in the iframe
> being unloaded?

It is not rendering, the content load and it remains loaded.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I don't think this is blocking then.

Joe: This might still be something that someone in the gfx might want to look at. But it's not a blocker so it's a low priority from the B2G side.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: remove.bug809031-workaround.patch

Salva, it seems that something has been fixed in the last year or so and the hack is not required anymore. Can you double check ?

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8373218 [details] [diff] [review]
remove.bug809031-workaround.patch

Working perfect. Thank you Vivien for get rid of this filthy trick ;)!

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/a96ee8fc78d05cd6bc26470ec3812482c2100759

Comment 7

[Noemí Freire (:noemi)]

nominating to v1.3T since it blocks a blocker (Bug 858017). Thanks!

Comment 8

[Steven Yang [:styang]]

Hi James/Ying, please take it for 1.3T. Thanks!

Comment 9

[James Zhang (Spreadtrum)]

conflicts, please update patch.

jameszhang@ffos1:~/sp6821a_gonk4.0/B2G/gaia$ git cherry-pick 73ac1320bb4c978a174f0d2c99ead515ddbb0a04
error: could not apply 73ac132... Bug 809031 - OOP <iframe> content disappear if placed below 147px inside the system. r=salva
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Comment 10

[James Zhang (Spreadtrum)]

Can I delete this file?

deleted by us:      build/jshint/xfail.list

Comment 11

[James Zhang (Spreadtrum)]

https://github.com/sprd-ffos/gaia/commit/d79dd6f92260570d49a65838744af96525dbbdf8

Please help to confirm this pull request, thanks.

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to James Zhang from comment #11)
> https://github.com/sprd-ffos/gaia/commit/
> d79dd6f92260570d49a65838744af96525dbbdf8
> 
> Please help to confirm this pull request, thanks.

That sounds good to me.

Comment 13

[James Zhang (Spreadtrum)]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #12)
> (In reply to James Zhang from comment #11)
> > https://github.com/sprd-ffos/gaia/commit/
> > d79dd6f92260570d49a65838744af96525dbbdf8
> > 
> > Please help to confirm this pull request, thanks.
> 
> That sounds good to me.

Thank you.
https://github.com/mozilla-b2g/gaia/commit/8ee9719e795f48cc773065d72feedc16efcd9b11

Comment 14

[bhavana bajaj [:bajaj]]

(In reply to Vivien Nicolas (:vingtetun) (:21) from comment #6)
> https://github.com/mozilla-b2g/gaia/commit/
> a96ee8fc78d05cd6bc26470ec3812482c2100759

marking 1.4 : fixed per this commit, which is when 1.4 was master.