Closed Bug 809039 Opened 12 years ago Closed 12 years ago

[Contacts] Updating pictures in contact list after synchronization of Facebook friends

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Project Flags:
blocking-basecamp +

People

(Reporter: crdlc, Assigned: crdlc)

Details

Attachments

(2 files)

Fixed and tests
7.44 KB, text/plain
arcturus
: review+
arcturus
: approval-gaia-v1+
Details
Patch bug reopened
4.48 KB, text/plain
crdlc
: review+
arcturus
: approval-gaia-v1+
Details
No description provided.
Assignee: nobody → crdlc
blocking-basecamp: --- → ?
Attached file Fixed and tests —
Attachment #678750 - Flags: review?(francisco.jordano)
Status: NEW → ASSIGNED
Attachment #678750 - Flags: review?(francisco.jordano) → review+
Comment on attachment 678750 [details] Fixed and tests NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #678750 - Flags: approval-gaia-master?(francisco.jordano)
Attachment #678750 - Flags: approval-gaia-master?(francisco.jordano) → approval-gaia-master+
https://github.com/mozilla-b2g/gaia/commit/98f43dbe8c51177861ef1981ccf64e1f4807fa7c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reopened as we have discovered that we need to wait for a pending sync for refreshing the contact list.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached file Patch bug reopened —
Follow the PR and comments at https://github.com/mozilla-b2g/gaia/pull/6240
Attachment #679115 - Flags: review?(crdlc)
ohh good idea, thanks Jose
Attachment #679115 - Flags: review?(crdlc) → review+
Comment on attachment 679115 [details] Patch bug reopened NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed: Risk to taking this patch (and alternatives if risky):
Attachment #679115 - Flags: approval-gaia-master?(francisco.jordano)
Comment on attachment 679115 [details] Patch bug reopened Integration tests and unit tests passing, loving it.
Attachment #679115 - Flags: approval-gaia-master?(francisco.jordano) → approval-gaia-master+
https://github.com/mozilla-b2g/gaia/commit/e92386b7869a94cdb78c0b9ca3c5a8e55af5403c
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
blocking-basecamp: ? → +
Priority: -- → P1
Verified Unagi build id:20130102070202
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: