809077 - The memory limit of image decoding will cause the image loading with twinkling

Status: RESOLVED DUPLICATE of bug 807143

(Firefox OS Graveyard :: General, defect)

Description

[John Shih]

With the memory limit of image decoding which is added by
releases-mozilla-aurora: 380077b562e6af7ba12f2375e36cbc8ffc8bf32b
(https://github.com/mozilla/releases-mozilla-aurora/commit/380077b562e6af7ba12f2375e36cbc8ffc8bf32b)

The image loading will encounter the twinkling problem

Comment 1

[Justin Lebar (not reading bugmail)]

Can you describe "twinkling"?

Comment 2

[Justin Lebar (not reading bugmail)]

I think the basic problem is combining a low limit here with 

  pref("content.image.allow_locking", false);

I don't think we can have both a low limit and locking disabled.  But maybe Joe has another idea.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

twinkling = flicker from what I just heard from someone else.

Comment 4

[John Shih]

Thanks Naoki, that's exactly what I mean (more precise is "appear and disappear)
and it also cause some other problems (please see depended bugs)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Ian, let's start lowering the visual impact by removing this line

https://github.com/mozilla-b2g/gaia/blob/master/apps/clock/style/clock.css#L7

The diagonal pattern is nice, but it brings more harm than good now...

Comment 6

[Joe Drew (not getting mail)]

(In reply to Justin Lebar [:jlebar] from comment #2)
> I think the basic problem is combining a low limit here with 
> 
>   pref("content.image.allow_locking", false);
> 
> I don't think we can have both a low limit and locking disabled.  But maybe
> Joe has another idea.

The two, AFAICT, are orthogonal. The cache limit only applies to those images that are unused.

Comment 7

[Justin Lebar (not reading bugmail)]

(In reply to Joe Drew (:JOEDREW! \o/) from comment #6)
> The two, AFAICT, are orthogonal. The cache limit only applies to those
> images that are unused.

The cache limit applies to those images which are discardable.  If image locking is disabled, then all images are discardable, no?

Comment 8

[Justin Lebar (not reading bugmail)]

Consolidating this discussion...

Comment 9

[Joe Drew (not getting mail)]

(In reply to Justin Lebar [:jlebar] from comment #7)
> (In reply to Joe Drew (:JOEDREW! \o/) from comment #6)
> > The two, AFAICT, are orthogonal. The cache limit only applies to those
> > images that are unused.
> 
> The cache limit applies to those images which are discardable.  If image
> locking is disabled, then all images are discardable, no?

Sorry, misread which size was changed in the link in comment 0. Ignore me.

Comment 10

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6274

Pointer to Github pull-request

Comment 11

[[e-mail], [e-mail]]

Comment on attachment 679519 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6274

To lower the visual impact fot Clock APP.
Modify CSS only.

Comment 12

[[e-mail], [e-mail]]

(In reply to Ian Liu [:ianliu] from comment #11)
> Comment on attachment 679519 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6274
> 
> To lower the visual impact fot Clock APP.
> Modify CSS only.

According comment 5, the patch will lower the visual impact and improve visual during launch Clock APP.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 679519 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6274

This looks good to me, but please file a Gaia bug for that so we could land this in the name of that bug. You would have to update the commit message also. We are not landing a patch with a DUP bug number.

Please write the commit message based on the solution rather than the comment.

Comment 14

[[e-mail], [e-mail]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #13)
> Comment on attachment 679519 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6274
> 
> This looks good to me, but please file a Gaia bug for that so we could land
> this in the name of that bug. You would have to update the commit message
> also. We are not landing a patch with a DUP bug number.
> 
> Please write the commit message based on the solution rather than the
> comment.

Let's do the improvement in Bug 810756 - Lower the visual impact during launch Clock APP.