80912 - CR/LF problem in DEFINES in nsprpub autoconf.mk

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Jörg Brunsmann]

* I downloaded mozilla 0.9 source code.
* I read http://mozilla.org/build/win32.html
* I changed mozilla/nsprpub/gmakefile.win to use 'bash' instead of 'sh'
* I typed 
  $ nmake /f client.mak build_all
* I saw
	gmake -f gmakefile.win MOZ_SRC_FLIPPED=c:/mozilla/source
cd WIN32_D.OBJ/ ; \
	bash ../configure --with-mozilla --with-dist-
prefix=c:/mozilla/source/mozilla/dist --with-dist-
bindir=c:/mozilla/source/mozilla/dist/WIN32_D.OBJ/bin --with-dist-
libdir=c:/mozilla/source/mozilla/dist/WIN32_D.OBJ/lib
creating cache ./config.cache
checking host system type... i586-pc-msvc
checking target system type... i586-pc-msvc
checking build system type... i586-pc-msvc
updating cache ./config.cache
creating ./config.status
creating Makefile
creating config/Makefile
creating config/autoconf.mk
creating config/nsprincl.mk
creating config/nsprincl.sh
creating config/nspr-config
creating lib/Makefile
creating lib/ds/Makefile
creating lib/libc/Makefile
creating lib/libc/include/Makefile
creating lib/libc/src/Makefile
creating pr/Makefile
creating pr/include/Makefile
creating pr/include/md/Makefile
creating pr/include/obsolete/Makefile
creating pr/include/private/Makefile
creating pr/src/Makefile
creating pr/src/io/Makefile
creating pr/src/linking/Makefile
creating pr/src/malloc/Makefile
creating pr/src/md/Makefile
creating pr/src/md/windows/Makefile
creating pr/src/memory/Makefile
creating pr/src/misc/Makefile
creating pr/src/threads/Makefile
creating pr/tests/Makefile
creating pr/tests/dll/Makefile
creating pr/src/threads/combined/Makefile
gmake -C WIN32_D.OBJ
gmake[1]: Entering directory `c:\mozilla\source\mozilla\nsprpub\WIN32_D.OBJ'
gmake[2]: Entering directory 
`c:\mozilla\source\mozilla\nsprpub\WIN32_D.OBJ\config'
cl -FoWIN954.0_DBG.OBJD/now.obj -c  -Od -Z7   -W3 -nologo -GF -Gy -MDd    -
UNDEBUG 
 -DUSE_AUTOCONF=1
 -DMOZILLA_CLIENT=1
 -DDEBUG=1
 -DDEBUG_db2admin=1
 -DXP_PC=1
 -DWIN32=1
 -DWIN95=1
 -D_PR_GLOBAL_THREADS_ONLY=1
 -D_X86_=1
  -DFORCE_PR_LOG   ../../config/now.c

This command isn't executed because the DEFINES which are defined
in nsprpub/config/autoconf.mk are separated by a NL or a CR.
Therefore the command line isn't executed by the MS-DOS shell.
If I edit autoconf.mk and put all defines in one line it builds.

Any idea how to overcome this problem?

Comment 1

[Boris Zbarsky [:bzbarsky]]

This does not seem to be an issue in a current trunk pull, btw...

Comment 2

[Jörg Brunsmann]

I just pulled mozilla/nsprpub from cvs. 
It's still an issue on my machine. I'll
save the autoconf.mk file as an attachment.

Comment 3

[Jörg Brunsmann]

Attachment: nsprpub/config/autoconf.mk

Comment 4

[Keyser Sose]

Marking NEW.

Comment 5

[hacker formerly known as [e-mail]]

Reporter, are you still seeing this problem? I haven't seen this problem in any 
of my builds.  

Comment 6

[Jörg Brunsmann]

Chris, yes I do see these problems in recent builds. 
If I knew which program builds the autoconf.mk file, I
would be able to give you some version information
about the used software. Thanks.

Comment 7

[hacker formerly known as [e-mail]]

Configure generates the autoconf.mk file.  When you installed cygwin, did you
tell it to use unix line endings or dos line endings?  I don't know if it makes
a difference but I use unix line-endings.

Comment 8

[Jörg Brunsmann]

Since I couldn't remember if I used unix or dos line-endings, 
I just installed cygwin 1.3.5 with unix line-endings. Unfortunately,
it doesn't make any difference. Since it seems to be a local
problem on my machine it maybe ok to close the bug. Thanks.

Comment 9

[hacker formerly known as [e-mail]]

what happens if you change mozilla/nsprpub/gmakefile.win back to using 'sh' and
install ash as sh.exe ?

Comment 10

[Jörg Brunsmann]

Thanks for your suggestion. I just installed ash.exe
as sh.exe, but unfortunately the problem persists.

Comment 11

[hacker formerly known as [e-mail]]

What source tree are you currently using?  I looked at that file again and the
^M's that its adding should be fixed by this line from nsprpub/configure:

DEFS=`sed -f conftest.defs confdefs.h | tr '\012' ' '| tr '\015' ' '`

That line wasn't added until recently though (0.9.6 timeframe iirc). 

Comment 12

[Jörg Brunsmann]

I'm using the 0.9.4 source code. If I
change the line as suggested to

DEFS=`sed -f conftest.defs confdefs.h | tr '\012' ' '| tr '\015' ' '`

it works. Great. Thanks.

Comment 13

[hacker formerly known as [e-mail]]

Marking fixed.