809145 - Awesomescreen filtering doesn't work if it's initiated from the bookmark or history screens

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Matthew N. [:MattN]]

Typing in the addressbar/searchbox from the history or bookmarks screen doesn't filter or highlight results like it does from "Top Sites".

Having the search box not work like the Top Sites tab makes for a confusing experience which led me to file bug 808917 and bug 808916 for separate filtering support.

Comment 1

[Ben Francis [:benfrancis]]

This is by design and is consistent with Firefox Mobile.

Comment 2

[Matthew N. [:MattN]]

(In reply to Ben Francis [:benfrancis] from comment #1)
> This is by design and is consistent with Firefox Mobile.

Actually, it does show a filtered awesomescreen on Firefox Mobile and the design[1]
simply says:

"When the user begins typing, the highlighted text is cleared and the Top Sites/Bookmarks/History tabs disappear. As he types, a list of relevant results filtered by frecency is displayed."

[1] https://www.dropbox.com/sh/ygwfxk6chpshxdj/wj9SyPP909/Apps/Browser/R1_AwesomeScreen_v4.pdf (Page 2)

Comment 3

[Ben Francis [:benfrancis]]

Oh sorry, I misunderstood your bug report. I thought this was somehow a meta bug of the other two.

Yes, you should get the same awesomescreen results regardless of which tab you start typing from (Top Sites, Bookmarks or History).

I think this may be a regression.

Comment 4

[Alex Keybl [:akeybl]]

Milestoning for C2 (deadline of 12/10), as this meets the criteria of "known P2 bugs found before or during C1".

Comment 5

[Michał Budzyński (:michalbe)]

Attachment: patch

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Michal Budzynski (:michalbe) from comment #5)
> Created attachment 682020 [details]
> patch

Michal do you meant to ask review to someone?

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 682020 [details]
patch

Ben told me you need some changes to this code. So carrying r-.

Comment 8

[Ben Francis [:benfrancis]]

Comment on attachment 682020 [details]
patch

r+me with the completed revisions.

Comment 9

[Ben Francis [:benfrancis]]

https://github.com/mozilla-b2g/gaia/commit/243eaf090186e90c296472c80795191d3d688136

Comment 11

[Matthew N. [:MattN]]

Thanks everyone.  I verified the fix on the stable update channel for b2gtd.