Advanced Search <select> CSS assumes white background-color



6 years ago
5 years ago


(Reporter: dominik, Unassigned)


Firefox Tracking Flags

(Not tracked)




6 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.16 (KHTML, like Gecko) Chrome/24.0.1305.3 Safari/537.16

Steps to reproduce:

Advanced Search CSS has grey as it's "selected color" for options and assumes white as the background-color for the <select> tags, though this is not true for all browsers (e.g. chrome has background-color: rgb(221, 221, 221); )

GitHub PR follows shortly.

Comment 1

6 years ago
Would be helpful here to note which site/implementation you're seeing this on (esp. as the team is working on a complete UI rewrite right now).

Comment 2

6 years ago
Hi Robert, the PR is here:

rhelmer's comments from IRC:

<rhelmer> dominikd: looks good to me, but we are trying to keep it as close to the old site as possible until we ship, so we probably won't merge that until after we stage this at least

Here's how it currently looks under Chrome (UA is above):
Given the work on the new search UI (bug 844793), we might not want to put too much here.

Comment 4

5 years ago
Given the work on the new search ui, is this still a problem?
Flags: needinfo?(adrian)
This doesn't seem to happen on Chromium anymore. Anyway, the original pull request was not accepted, and we don't want to spend time working on compatibility with Webkit browser. 

I'm happy to review another pull request though, if the problem is still there.
Last Resolved: 5 years ago
Flags: needinfo?(adrian)
Resolution: --- → INVALID
Bumping to verified invalid - per comment 5. Do indeed followup with pull request(s) if there are issues that you see can be resolved.
You need to log in before you can comment on or make changes to this bug.