809179 - Please reinstate the js -w and -s command-line options

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Eric Promislow]

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:15.0) Gecko/20100101 Firefox/15.0.1
Build ID: 20120905151427

Steps to reproduce:

Komodo uses the js shell to check JavaScript syntax, using a combination of the -C, -w, and -s options for compile-only, give warnings, and strict warnings (not 'use strict').  


Actual results:

The shell's command-line parser wasn't happy.  "-C" is now "-c", and -w and -s are gone.


Expected results:

Should we look for a different core JavaScript parser to do syntax-checking?  We currently offer support for jshint and jslint as alternatives, but both these packages typically lag the state of EcmaScript by a version or two.  

In a perfect world interfaces never change while internals continue to advance :)

Comment 1

[Eric Promislow]

Attachment: The back-end still implements these options; reinstate them in the front end

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 678998 [details] [diff] [review]
The back-end still implements these options; reinstate them in the front end

Review of attachment 678998 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +4764,5 @@
> +        reportWarnings = JS_FALSE;
> +    
> +    if (op->getBoolOption('s')) {
> +        JS_ToggleOptions(cx, JSOPTION_STRICT);
> +    }

nit: no braces needed here

Comment 3

[Eric Promislow]

Attachment: Removed extraneous braces from above patch

Comment 4

[Eric Promislow]

Komodo app builds and runs correctly with https://bugzilla.mozilla.org/attachment.cgi?id=679911 

I don't have checkin status.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4be5aca0d6cf

Thanks for the patch, Eric! One request - to make life easier for those checking in on your behalf, please make sure that your future patches are made per the guidelines below. Thanks again!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Also, I'm not sure what source repository you generated this patch from, but please make sure futures ones are against mozilla-central as this one most assuredly was not.

Comment 6

[[e-mail]]

(In reply to Ryan VanderMeulen from comment #5)
> I'm not sure what source repository you generated this patch from
http://forums.mozillazine.org/viewtopic.php?f=23&t=2557877 suggests aurora.

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/4be5aca0d6cf

Comment 8

[Eric Promislow]

Yes, taken from Aurora. I've bookmarked the link for making patches
in the future.