809283 - New folder in bookmarks should go at the bottom of list

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[Jhon H. Caicedo]

Attachment: Firefox_NewFolder.jpg

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20100101 Firefox/16.0
Build ID: 20121024073032

Steps to reproduce:

Open the bookmarks window, right click on the folder list and select create new folder.



Actual results:

The new folder is not added to the bottom of the list but before the last element in the list. (attached image)


Expected results:

The element should be added after the last element in the list.

Comment 1

[Jhon H. Caicedo]

Have reproduced the bug on Firefox 16.0.2 running on: WinXP, Win7

Comment 2

[Paul Silaghi, QA [:pauly]]

> Actual results:
> 
> The new folder is not added to the bottom of the list but before the last
> element in the list. (attached image)

Actually the new folder is added just above the position of the cursor on the folders list.
Don't know the expected behavior, but I think it would be better the new folders to be sorted by the date or at least alphabetically.

Comment 3

[Jhon H. Caicedo]

Run some tests, in Firefox 17.0.1 (Win7) the odd behaviour continues.
- Agree with Paul, the new folder is added before the selected folder in the list and before the last element is nothing is selected, but there is no way to add a folder at the bottom of the list.

Comment 4

[Asaf Romano (gone)]

There are few different scenarios:
1) The context menu is opened for some folder *in the left pane*. The new folder is created at the bottom, as expected.
2) The context menu is opened for some selection *in the right* pane. The new folder is created above the selected item. This is by-design as far as I can tell (but I think we should change that, see below).
3) The context menu is opened at some empty area in the right pane, but there's some selection there (this is possible when there are very few items in there). This is handled just as the case above. It's arguably a bug.
4) The context menu is opened in the right pane when there's no selection. The folder is created above the last item. If I understand the report correctly, that's what this bug is about.

Indeed, the last scenario is a bug, but a very minor one now that bug 827293 is fixed (it made it so the right pane view is always loaded with the first item selected). One would have to accel+click the selected item first in order to clear the selection first.

The third scenario is how I, as a user, would try to create a folder at the bottom of the list. I may file a bug about it later.

However, I think we should change the second scenario to create the new item below the selected item, so it's easy and trivial to create a folder at the bottom even if there's no empty space at all.

Comment 5

[Jhon H. Caicedo]

I agree, the bug is nothing serious but has been there for years and the solution is trivial, create the new folder below the selected item or after the last item if there is no selection, that should cover all the cases outlined by Mano.

FYI, the way I handle bookmarks is having a folder for each year (2006-2013) and then create a new subfolder for each month, so I am interested in the folders ordered. Currently I create the folder and then have to drag it a the end of the list every time.

Thanks for taking the time to review this.

Comment 6

[Marco Bonardo [:mak]]

(In reply to Mano from comment #4)
> However, I think we should change the second scenario to create the new item
> below the selected item, so it's easy and trivial to create a folder at the
> bottom even if there's no empty space at all.

We always create above in all of the views (menu, toolbar and treeview), I don't remember the reason we choose above off-hand but I'm sure there was a valid one. Regardless above or below, we should be coherent in all of the views.

Comment 7

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.