Closed
Bug 809293
Opened 12 years ago
Closed 12 years ago
[Settings] developer info in Application Permissions always links to http://github.com/mozilla-b2g/gaia/
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P3)
Tracking
(blocking-basecamp:+)
VERIFIED
FIXED
blocking-basecamp | + |
People
(Reporter: MattN, Assigned: MattN)
Details
(Keywords: b2g-testdriver)
Attachments
(1 file)
developerName.href never gets changed from http://github.com/mozilla-b2g/gaia/ in apps/settings/js/apps.js Clicking on the developer name always links to http://github.com/mozilla-b2g/gaia/
Assignee | ||
Comment 1•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #679020 -
Flags: review?(21)
Assignee | ||
Comment 2•12 years ago
|
||
This was because the code only looked at the data-href for external URLs but that was not getting updated when switching apps in the permission screen. While fixing this I realized it also affected the developer's URL line as well.
Summary: [Settings] developer name in Application Permissions always links to http://github.com/mozilla-b2g/gaia/ → [Settings] developer info in Application Permissions always links to http://github.com/mozilla-b2g/gaia/
Comment 3•12 years ago
|
||
Comment on attachment 679020 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6226 Mostly Etienne's code. Let's redirect the review.
Attachment #679020 -
Flags: review?(21) → review?(etienne)
Comment 4•12 years ago
|
||
Hey Matthew, commented on the pull request, just a small change needed. Thanks for the fix!
Updated•12 years ago
|
Attachment #679020 -
Flags: review?(etienne) → review+
Updated•12 years ago
|
blocking-basecamp: ? → +
Priority: -- → P3
Comment 5•12 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/a8e3fd1481263a705a546544ef20b4005cc5b9cf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Component: Gaia → Gaia::Settings
Comment 6•12 years ago
|
||
Looks good. Verified on 11/26.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•