809293 - [Settings] developer info in Application Permissions always links to http://github.com/mozilla-b2g/gaia/

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P3)

Description

[Matthew N. [:MattN]]

developerName.href never gets changed from http://github.com/mozilla-b2g/gaia/ in apps/settings/js/apps.js

Clicking on the developer name always links to http://github.com/mozilla-b2g/gaia/

Comment 1

[Matthew N. [:MattN]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6226

Pointer to Github pull-request

Comment 2

[Matthew N. [:MattN]]

This was because the code only looked at the data-href for external URLs but that was not getting updated when switching apps in the permission screen. While fixing this I realized it also affected the developer's URL line as well.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 679020 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6226

Mostly Etienne's code. Let's redirect the review.

Comment 4

[Etienne Segonzac (:etienne)]

Hey Matthew, commented on the pull request, just a small change needed.

Thanks for the fix!

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/a8e3fd1481263a705a546544ef20b4005cc5b9cf

Comment 6

[Jason Smith [:jsmith]]

Looks good. Verified on 11/26.