809611 - [Keyboard] Long press key selection is reversed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P2)

Description

[Patryk Adamczyk [:patryk] UX]

Attachment: Incorrect selection.

See screenshots.
The issue here is that on long press the incorrect letter has a highlight.

What should happen, is when a long press mode is activated (new characters appear) the cyan highlight should only appear under the user's finger. So in the case of the long press "l", the highlight should only appear under the "l", or the "£" or the "ł" symbol, as when the user raises their finger from the screen, that selected character will appear in the input field.

Comment 1

[Patryk Adamczyk [:patryk] UX]

Attachment: Wierd double selection... this happens as well... sometimes.

Comment 2

[Staś Małolepszy :stas]

Actually, I think the right letter is highlighted, but confusingly, the highlight is dark-grey and not cyan.

Comment 3

[Gordon Brander :gordonb]

Attachment: Patch fixes highlight color of special characters.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): #809611
User impact if declined: Confusion about what key is selected (you don't know which letter you are typing).
Testing completed: n/a (small CSS change -- verified on-device)
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 681286 [details] [diff] [review]
Patch fixes highlight color of special characters.

You usually want to ask approval-gaia-master to someone specifically (e.g you need to add :vingtetun in the field) otherwise nobody will see it :)

I would deny it assuming this change can go into your own branch and land with the other changes you will made. 

I tend to think that you should not try to land things on master that are css only, or do one pull request per feature. This create a lot of noise and make less appreciable the benefit of your ux fork (imho).

In a review point of view we also try to avoid dead code, so instead of commenting it it should be removed.

Comment 5

[Gordon Brander :gordonb]

> You usually want to ask approval-gaia-master to someone specifically
> (e.g you need to add :vingtetun in the field) otherwise nobody will see it :)

Thanks for your help -- still learning the ins and outs of how this team uses Bugzilla :)

> In a review point of view we also try to avoid dead code, so
> instead of commenting it it should be removed.

I'm a little bit confused, because I don't see any commented-out code in the commit. I don't like commented-out code either!

> or do one pull request per feature.

Just want to double-check on this one: I flattened all my commits into a single commit for the fix. My understanding is that this is the process we want to follow. LMK if I'm missing something.

> I tend to think that you should not try to land things on
> master that are css only ...
> This create a lot of noise and make less appreciable the
> benefit of your ux fork (imho).

That's ok, too. In this case I nominated it because it is a usability issue.

Thanks again for your feedback!

Comment 6

[Gordon Brander :gordonb]

Fix merged into UX branch: https://github.com/gordonbrander/gaia/commit/5f41767e48c3222188546dfb5a6c2b925bd71848

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified in ux branch

commit 685a0e7cdeb5871782cb9edfc35b7f2f417e79fb
Merge: 8a27be6 2b67e99
Author: Gordon Brander <[e-mail]>
Date:   Tue Nov 20 12:15:40 2012 +0100

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/28993615812d48b3b77ce4c613c66d8805a3a0ca

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Master build : 2013-03-25-03-07-06
"mozilla-central" revision="bef19bca23f9"
"integration/gaia-central" revision="8c401e09a6a9"
"gecko.git"revision="bbaac6bbbf5084ef1a3e178ced676ea77db8b24b"
"gaia.git" revision="a1259a6c80629daa458428d6a96403841aaab0f0"

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/dec694d585e1
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
BuildID 20130325070203
Version 18.0
Unagi