809625 - [socorro-crashstats] page=0 parameter makes report/list throw a 500

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://crash-stats-new-dev.allizom.org/report/list?range_unit=days&version=Firefox%3A19.0a1&signature=mozilla%3A%3Aimage%3A%3ARasterImage%3A%3ADiscard%28bool%29&date=2012-11-04&range_value=7&page=0 throws a 500 (page=0)

Comment 1

[Robert Helmer [:rhelmer]]

Traceback:
File "/home/rhelmer/src/socorro-crashstats/vendor/lib/python/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in inner
  155.         return view(request, *args, **kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in report_list
  967.         result_offset=result_offset
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/models.py" in get
  430.         return self.fetch(url)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/models.py" in fetch
  126.             raise BadStatusCodeError('%s: on: %s' % (resp.status_code, url))

Exception Type: BadStatusCodeError at /report/list
Exception Value: 500: on: http://socorro1.dev.dmz.phx1.mozilla.com/bpapi/report/list/plugin_search_mode/contains/to/2012-11-04T00%3A00%3A00/versions/Firefox%3A19.0a1/result_number/250/plugin_in/filename/products/Firefox/report_type/any/signature/mozilla%3A%3Aimage%3A%3ARasterImage%3A%3ADiscard%28bool%29/report_process/any/from/2012-10-28T00%3A00%3A00/result_offset/-250

Comment 2

[Robert Helmer [:rhelmer]]

r? https://github.com/mozilla/socorro-crashstats/pull/279

This is the same approach that the hangreport uses.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/2e4d72d60683fb36b94029fa9ed0a6e47c4f1361
fixes bug 809625 reset negative pages to 1

https://github.com/mozilla/socorro-crashstats/commit/4294d2e00eb179c2d282cb757ef5dd31d7e945f8
Merge pull request #279 from rhelmer/bug809625-negative-pages-not-allowed

fixes bug 809625 reset negative pages to 1

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!

[11:18:08.007] GET http://crash-stats-new-dev.allizom.org/report/list?range_unit=days&version=Firefox%3A19.0a1&signature=mozilla%3A%3Aimage%3A%3ARasterImage%3A%3ADiscard%28bool%29&date=2012-11-04&range_value=7&page=0 [HTTP/1.1 200 OK 335ms]