Closed Bug 809659 Opened 12 years ago Closed 12 years ago

[socorro-crashstats] report/list throws a 500, needs more form validation

Categories

(Socorro :: Webapp, task)

task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stephend, Assigned: rhelmer)

References

()

Details

(Whiteboard: [fuzzer])

Traceback:
File "/home/rhelmer/src/socorro-crashstats/vendor/lib/python/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in inner
  155.         return view(request, *args, **kwargs)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/views.py" in report_list
  1056.         result_offset=result_offset
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/models.py" in get
  502.         return self.fetch(url)
File "/home/rhelmer/src/socorro-crashstats/crashstats/crashstats/models.py" in fetch
  126.             raise BadStatusCodeError('%s: on: %s' % (resp.status_code, url))

Exception Type: BadStatusCodeError at /report/list
Exception Value: 500: on: http://socorro1.dev.dmz.phx1.mozilla.com/bpapi/crashes/comments/plugin_search_mode/contains/to/2012-11-07T00%3A00%3A00/versions/Firefox%3A19.0a1/result_number/250/plugin_in/filename/products/Firefox/report_type//etc/passwd/signature/Crash/report_process/any/from/2012-10-24T00%3A00%3A00/result_offset/0
Looking at this more closely, it's not the signature field that has the extra / it's that we're not validating hang_type (or most of the other fields) as we do in e.g. DailyForm
Summary: [socorro-crashstats] report/list throws a 500, due to encoding problems → [socorro-crashstats] report/list throws a 500, needs more form validation
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/80d6bc57d27991700df0f242f582cfe15d542897
bug 809659 - more complete form validation for report/list and /query, which is based on this

https://github.com/mozilla/socorro-crashstats/commit/bc47d6ca5bbc9ae0eebba95dcf2c6301b7a523f9
Merge pull request #284 from rhelmer/bug809659-report-list-form-validations

bug 809659 - more complete form validation for report/list and /query, w...
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified per comment 12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.