809687 - Add Facebook Messenger for Firefox Affiliate buttons to Facebook application

Status: RESOLVED WONTFIX

(Firefox Affiliates Graveyard :: Social Integration, defect)

Description

[Chelsea Novak [:chelsea]]

Hey team, 

So when we launch the social API, we'd like to add Affiliate buttons for Facebook Messenger for Firefox to the app. 

I'm fine swapping out one of the existing buttons to make room for the new buttons so that we can avoid strings. Good idea or madness?

Comment 1

[Osmose [:osmose, :mkelly]]

Probably not a good idea, as it might cause issues with people who already use those buttons.

IMO it wouldn't be a huge deal to just use the new strings from 809685 and put them out un-translated for a week or two.

Comment 2

[Osmose [:osmose, :mkelly]]

Oh, I'm dumb, this is for the Facebook application.

We'll still need (not blocking) alt strings for the banners, but yeah, we can replace existing banners. We can also look into adding an extra row of images, would that be better?

Comment 3

[Chelsea Novak [:chelsea]]

I would love to add an extra row of images. But at most I'd have two available for this. Would that break the layout?

Comment 4

[Osmose [:osmose, :mkelly]]

Attachment: Yes!

Yes we can! (Quick test courtesy of Firebug)

Comment 5

[Chelsea Novak [:chelsea]]

Comment on attachment 679747 [details]
Yes!

Sold!

Comment 6

[Osmose [:osmose, :mkelly]]

So, just to be clear, this shouldn't require any dev effort except to add the alt text to be localized. Adding them to the admin interface should just work (we can test on stage first to make sure).

Comment 7

[Chelsea Novak [:chelsea]]

I love it when a plan comes together.