Please report any other irregularities here.
CSPService currently uses the node to extract out the principal. This does not, imo, encourage trust in the code. We should use the new aRequestPrincipal argument instead.
Comment on attachment 679536 [details] [diff] [review] Change CSP code to use aRequestPrincipal Try run is https://tbpl.mozilla.org/?tree=Try&rev=787d9ee7396d
Attachment #679536 - Flags: review?(bzbarsky)
Comment on attachment 679536 [details] [diff] [review] Change CSP code to use aRequestPrincipal r=me
Attachment #679536 - Flags: review?(bzbarsky) → review+
I am planning on requesting a checkin. There is only 1 CSP test failing, and its a timeout for a worker test. Other worker tests seem to be working fine, and this one is timing out repeatedly. Please let me know if you think I shouldn't request checkin, or if you think I should run the tests on more platforms.
No, you shouldn't be checking things in with known test failures. Either fix the failure or disable the test.
Resolving this WONTFIX. Seems that addons call contentpolicy directly, and thus, we can't rely on aRequestPrincipal existing.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.