80982 - plugin crashes when loading http://chinese.china.com/zh_cn

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Yuying Long]

build: 0515 trunk build

Steps to reproduce:
Launch the browser and go: http://chinese.china.com/zh-cn
   or http://www.china.com then click on link "Simp. Chinese"

Then you will see this crash.
Note I didn't see this crash on 05-11 trunk build though.

Comment 1

[Yuying Long]

add keywords and change QA contact to myself.

Comment 2

[nhottanscp]

Is there a talkback result available?

Reassign to ftang.

Comment 3

[Yuying Long]

Talkback ID 30476011
-----------------------------------------------------------------------------
Call Stack:    (Signature = free() 2a5e4d06)  
     free()  [nsAllocatorManager.cp] 
     PL_strfree()  [strdup.c, line 44] 
     nsPluginStreamListenerPeer::SetUpStreamListener()  [nsPluginHostImpl.cpp, 
line 1622] 
     nsPluginStreamListenerPeer::OnStartRequest()  [nsPluginHostImpl.cpp, line 
1413] 
     nsHttpChannel::ProcessNormal()  [nsHttpChannel.cpp, line 430] 
     nsHttpChannel::ProcessResponse()  [nsHttpChannel.cpp, line 403] 
     nsHttpChannel::OnStartRequest()  [nsHttpChannel.cpp, line 1915] 
     nsOnStartRequestEvent::HandleEvent()  [nsRequestObserverProxy.cpp, line 
108] 
     nsARequestObserverEvent::HandlePLEvent()  [nsRequestObserverProxy.cpp, line 
63] 
     PL_HandleEvent()  [plevent.c, line 588] 
     PL_ProcessPendingEvents()  [plevent.c, line 518] 
     nsEventQueueImpl::ProcessPendingEvents()  [nsEventQueue.cpp, line 374] 
     nsEventQueueImpl::ProcessPendingEvents()  [nsEventQueue.cpp, line 380] 
     nsMacNSPREventQueueHandler::ProcessPLEventQueue()  [nsToolkit.cpp, line 
135] 
     nsMacNSPREventQueueHandler::RepeatAction()  [nsToolkit.cpp, line 99] 
     Repeater::DoRepeaters()  [nsRepeater.cpp, line 119] 
     nsMacMessagePump::DispatchEvent()  [nsMacMessagePump.cpp, line 451] 
     nsMacMessagePump::DoMessagePump()  [nsMacMessagePump.cpp, line 255] 
     nsAppShell::Run()  [nsAppShell.cpp, line 110] 
     nsAppShellService::Run()  [nsAppShellService.cpp, line 416] 
     Netscape 6 + 0x469c (0x1d7581bc)    
 

Comment 4

[Frank Tang]

The stack trace looks like nothing related to Chinese. 
cvsblame show av is the last one who touch this line. reassign to av to look at.

1613 av              1.232     if (lastModified) 
1614                           {
1615                             PRTime time64;
1616                             PR_ParseTimeString(lastModified, PR_TRUE, &
time64);  //convert string time to interger time
1617 peterlubczynski 1.188  
1618 av              1.232       // Convert PRTime to unix-style time_t, i.e. 
seconds since the epoch
1619                             double fpTime;
1620                             LL_L2D(fpTime, time64);
1621                             mPluginStreamInfo->
SetLastModified((PRUint32)(fpTime * 1e-6 + 0.5));
1622                             nsCRT::free(lastModified);
1623                           }

Comment 5

[sean echevarria]

Initializing lastModified to nsnull before the call to
httpChannel->GetResponseHeader("last-modified", &lastModified) might address the
crash.  Looks like GetResponseHeader() impl changed recently?

Comment 6

[Yuying Long]

Not crash on 05-17 build, but got blank page when click the links on this page.
filed another bug 81488.

Comment 7

[Peter Lubczynski]

Movnig off radar. Marking FIXED with recent check-in. If this still crashes at 
the same place, please re-open and assign to me. Use bug 81488 to deal with the 
other issues.

Comment 8

[Yuying Long]

I'll mark it as verified for now.