809909 - spdy/3 goaway frame wrong format

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

spdy/3 changed the format of the spdy go away frame, but we didn't update it.

twitter informed me of this - its not causing a big problem because its part of the shutdown sequence anyhow.

One of the reasons the format changed was to include a reason code which is also the reason in spdy/2 we only send GA on clean shutdowns.

So that makes this patch easy - always send OK as the reason code. It is quite safe to backport.

I'll put together a different bug for mozilla-central only that sends GoAway in some error cases.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Comment 2

[Patrick McManus [:mcmanus]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/c28e2bf7d490

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c28e2bf7d490

Should this have a test?

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

I got this:

/home/kanru/zone2/mozilla/central/netwerk/protocol/http/SpdySession3.cpp: In member function ‘virtual void mozilla::net::SpdySession3::Close(nsresult)’:
/home/kanru/zone2/mozilla/central/netwerk/protocol/http/SpdySession3.cpp:1873: error: ‘goawayReason’ is not a class or namespace

Comment 5

[Jeff Walden [:Waldo]]

Yeah, it's not kosher to have goawayreason::OK.  You can do that if you have a C++11 enum class, but not with normal C++ enums.  Could you update this to use mozilla/Attributes.h and MOZ_BEGIN_ENUM_CLASS/MOZ_END_ENUM_CLASS, please?