809929 - Allow reviewers to override device compatibility from the review detail page

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Wil Clouser [:clouserw]]

Read the spec (link below) for a full description of what's going on but the rough idea is that a reviewer will check out an app on all the devices it claims compatibility with.  If the app is approvable but has a substantial problem on a device it claims compatibility with the reviewer will simply remove the compatibility for that single device (leaving the others) and mention why they are doing so in the review comments.  This way apps will still move through the queue even if they need some tweaks on specific devices.

This bug is adjust the review detail page (eg. https://marketplace-dev.allizom.org/reviewers/apps/review/allow ).  When you click "Push to public" a form opens.  Please add a row between the "Tested with" row and the comments box which is labeled "Device Compatibility" and shows the 4 images from 

ID: US-Reviewer-Review-001
spec: https://docs.google.com/document/d/1z5hIHGRCGD2fqOVpX-SML6NzURqKygoaD8FQ3B-ehPg/edit

Comment 1

[Wil Clouser [:clouserw]]

"shows the 4 images from the main reviewer queue table."

Comment 2

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/484d64f
https://github.com/mozilla/zamboni/commit/541a65f

> ... labeled "Device Compatibility" and shows the 4 images ...

I just used checkboxes and text of each device.