810014 - If a reviewer changes device compatibility ensure the app does not get auto-published

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Wil Clouser [:clouserw]]

Note the bug dependencies.

If a reviewer changes the device compatibility before approving we should toggle the flag cvan is making in bug 810009 so the app is NOT published automatically.  Note that this is only for approving - if they change device compatibility and reject we don't need to change any flags.

ID: none
Spec: https://docs.google.com/document/d/1z5hIHGRCGD2fqOVpX-SML6NzURqKygoaD8FQ3B-ehPg/edit

Comment 1

[Rob Hudson [:robhudson]]

Why would a reviewer change device compatibility when rejecting?

As it is, both publicizing and rejecting use the same form, so this is nice. But I'm not seeing a reason rejection needs the device overrides.

Comment 2

[Wil Clouser [:clouserw]]

They wouldn't.  I was aiming for that in the first sentence by specifying "approving" but the second one should just be s/change device compatibility and//g

You're doing the right thing. :)

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/484d64f

With that commit, the device override checkboxes are still on the rejection form. I'll follow up to ensure that:

1) The rejection form doesn't have these checkboxes
2) The app won't change to the PUBLIC_WAITING status on rejection (with 1 that shouldn't happen, but could now)

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/39a0c5c 

This hides the device overrides when rejecting and takes care to not change devices in the case of form hackery.

Comment 5

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/reviewers/ on FF20 (Win 7)
Postfix screencast http://screencast.com/t/MuOiZbXMKMf
Closing bug.