Show filename in notifcation Title during download

VERIFIED FIXED in Firefox 19

Status

()

VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

unspecified
Firefox 19
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox19 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We current show a notification with a title of "Downloads" and a message with the filename, but when we're showing progress, the message isn't shown.

We should show the filename in the notication's Title (and show some state in the message "Starting", "Done", "Not enough space", "Failed", etc.)
(Assignee)

Comment 1

6 years ago
Created attachment 679893 [details] [diff] [review]
Patch

This changes our notifications to just have the filename as the title, and status as the msg. i.e. If I was downloading file.txt I would see:

|--| file.txt
|--| Download starting

|--| file.txt
|--| 50% ==============

|--| file.txt
|--| Download complete

I removed the prefix "Downloading: " from the title because it felt like wasted space on a small screen, but I'm open to talking about it. I'll mark this as feedback needed from ibarlow as well.
Attachment #679893 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

6 years ago
Flags: needinfo?(ibarlow)

Comment 2

6 years ago
Comment on attachment 679893 [details] [diff] [review]
Patch

Review of attachment 679893 [details] [diff] [review]:
-----------------------------------------------------------------

Shorter titles sound good to me. Just one comment to address before landing.

::: mobile/android/locales/en-US/chrome/browser.properties
@@ -12,5 @@
>  alertAddonsInstalled=Installation complete. Restart required.
>  alertAddonsInstalledNoRestart=Installation complete
>  alertAddonsFail=Installation failed
>  
> -alertDownloads=Downloads

I thought you accidentally deleted this, but now I see that it's not going to be used anymore because we won't call showAlert() without a title. If that's the case, let's get rid of that check in showAlert() to provide a default title:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/downloads.js#83
Attachment #679893 - Flags: review?(margaret.leibovic) → review+
How is this different than bug 741654.
(Assignee)

Comment 4

6 years ago
This has to do with the native android notifications. That has to do with about:downloads.
(In reply to Wesley Johnston (:wesj) from comment #1)
> Created attachment 679893 [details] [diff] [review]
> Patch
> 
> This changes our notifications to just have the filename as the title, and
> status as the msg. i.e. If I was downloading file.txt I would see:
> 
> |--| file.txt
> |--| Download starting
> 
> |--| file.txt
> |--| 50% ==============
> 
> |--| file.txt
> |--| Download complete
> 
> I removed the prefix "Downloading: " from the title because it felt like
> wasted space on a small screen, but I'm open to talking about it. I'll mark
> this as feedback needed from ibarlow as well.

This looks fine to me. In addition to saving space for a file name, showing download progress makes the word "Downloading" in the title bar somewhat redundant anyway.
Flags: needinfo?(ibarlow)
https://hg.mozilla.org/mozilla-central/rev/b0384bf925aa
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
The filename is displayed in Notification Bar as expected when downloads starts, when it's in progress and when it's done. Closing bug as verified fixed on:

Firefox 19.0a1 (2012-11-16)
Device: Galaxy S2
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
status-firefox19: --- → verified
You need to log in before you can comment on or make changes to this bug.