Closed Bug 810095 Opened 12 years ago Closed 12 years ago

Homescreen -- incorrect delete app icon

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86
macOS
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
RESOLVED FIXED
Milestone:
B2G C2 (20nov-10dec)
Project Flags:
blocking-basecamp +

People

(Reporter: gbrander, Assigned: vingtetun)

Details

(Whiteboard: visual design, incorrect implementation)

Attachments

(2 files)

delete app icon
1.04 KB, image/png
Details
Patch
3.94 KB, patch
etienne
: review+
Details | Diff | Splinter Review
Problem ------- Homescreen app is awesome, but the "delete" icon for apps needs new visuals -- I think it was accidentally sourced from the OSX widget dashboard. How to reproduce ---------------- 1. Tap and hold any app icon to go into "manage mode" 2. Observe icons. Solution -------- 1. Get new visuals from design team 2. Implement
Component: Gaia::Apps Management → Gaia::Homescreen
At closer inspection, it looks like a direct copy from OS X, so we need to replace it for legal reasons.
blocking-kilimanjaro: --- → ?
Whiteboard: incorrect implementation, design → visual design, incorrect implementation
Assignee: nobody → epang
blocking-basecamp: --- → ?
blocking-kilimanjaro: ? → ---
Eric please attach the correct design.
Priority: -- → P2
blocking-basecamp: ? → +
Attached image delete app icon —
Assignee: epang → padamczyk
Attachment #683944 - Flags: review?(etienne) → review+
Marking for C2, given this meets the criteria of known P1/P2 blocking-basecamp+ bugs at the end of C1.
Target Milestone: --- → B2G C2 (20nov-10dec)
Keywords: verifyme
QA Contact: jsmith
Fixed with https://github.com/mozilla-b2g/gaia/pull/6558
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We needed to also change the location.
Assignee: padamczyk → nobody
Flags: needinfo?(21)
Assignee: nobody → 21
(In reply to Patryk Adamczyk [:patryk] UX from comment #7) > Fixed with https://github.com/mozilla-b2g/gaia/pull/6558 I replied on github.
Flags: needinfo?(21)
Can we merge this before it bit rots? https://github.com/mozilla-b2g/gaia/pull/6590
(In reply to Patryk Adamczyk [:patryk] UX from comment #11) > Can we merge this before it bit rots? > https://github.com/mozilla-b2g/gaia/pull/6590 Your commit message is not set right :-/ but I think it met the lowest basic requirement (contains the bug number ...) I will still prefer let vingtetun to merge it :P
Flags: needinfo?(21)
https://github.com/mozilla-b2g/gaia/commit/3f1c504c636eaab3193df76d9ef7522b3f631e1a
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Flags: needinfo?(21)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: