Closed Bug 810154 Opened 12 years ago Closed 12 years ago

[email] Able to send mail without filling out any fields

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-basecamp:+)

VERIFIED FIXED
B2G C2 (20nov-10dec)
blocking-basecamp +

People

(Reporter: marcia, Assigned: steveck)

References

Details

(Keywords: regression, unagi)

Attachments

(1 file)

unagi,

Gaia: 7ffd1c81db16bf0c6c3285a46259411d603109ca
Gecko: f059d3668a1acdeca0fac3c489205edcbe3c8779

STR:
1. Set up a Gmail account
2. Bring up the compose window, and don't fill in any fields
3. Press Send

Expected:

I would get error feedback telling me I need to fill in the appropriate fields

Actual:

I get the "sending mail" notice and I cannot get out of that screen (have to reboot).
Hi Marcia,

I could not reproduce the blocking screen on my otoro device:
gaia: 18107c6961b8c3f559c82fc7be8ba411c4a67c28
gecko: 234e8d86cf78d3e07e05ca86434d177cfb3374b5

Although it didn't block the screen, but it didn't popup sent failed dialog either before back to message list page.
blocking-basecamp: --- → ?
bug 798715 is in regards to an empty email address...
Looking at both gaia... they are both from Nov 8th where as the bug I mentioned should have been fixed.

NH-MBP:gaia nhirata$ git show 7ffd1c81db16bf0c6c3285a46259411d603109ca
commit 7ffd1c81db16bf0c6c3285a46259411d603109ca
Merge: 93d53f0 1781ad3
Author: Dave Hylands <dhylands@gmail.com>
Date:   Thu Nov 8 00:23:57 2012 -0800

NH-MBP:gaia nhirata$ git show 18107c6961b8c3f559c82fc7be8ba411c4a67c28
commit 18107c6961b8c3f559c82fc7be8ba411c4a67c28
Merge: 233ee3f c66432a
Author: Alive.Kuo <alegnadise@gmail.com>
Date:   Thu Nov 8 16:23:31 2012 -0800

    Merge pull request #6301 from alivedise/bugzilla/809994/wake-the-phone-when-
    
    Bug 809994 - Turn screen on when the device is plugged.
Apparantly the email sends to yourself, thus bypassing the check.  
I was able to reproduce this issue.
Keywords: regression
This is with sending through gmail.  I have to try with hotmail and imap.
Keywords: qawanted
since the email is feedback there's no data loss.  pushing down to normal.
Severity: critical → normal
blocking+ / regression
blocking-basecamp: ? → +
Priority: -- → P2
Milestoning for C2 (deadline of 12/10), as this meets the criteria of "known P2 bugs found before or during C1".
Target Milestone: --- → B2G C2 (20nov-10dec)
Assignee: nobody → squibblyflabbetydoo
Assignee: squibblyflabbetydoo → schung
Hi Naoki,
Does the email still stuck in sending email view or it just doesn't have any error dialog while mail without filling out any fields(but it will switch back to message list)? And how about hotmail and other mail?

Hi Andrew,
During my testing, it seems the finishCompositionSendMessage callback error value would be null if email is gmail account(but it will be set to 'unknown' in hotmail account). Should I check the input fields before sending and popup the warning like "There must be at least one address in the To:, Cc:, or Bcc: fields" if there is no any receiver, or just let finishCompositionSendMessage callback to handle whether the message sent failed or not?
(In reply to Steve Chung from comment #8)
> Hi Andrew,
> During my testing, it seems the finishCompositionSendMessage callback error
> value would be null if email is gmail account(but it will be set to
> 'unknown' in hotmail account). Should I check the input fields before
> sending and popup the warning like "There must be at least one address in
> the To:, Cc:, or Bcc: fields" if there is no any receiver, or just let
> finishCompositionSendMessage callback to handle whether the message sent
> failed or not?

Hm, that might explain the other weirdness we are seeing with gmail...

Thunderbird shows an error dialog after starting the send process with a prompt of:
"Sending of message failed.
No recipients were specified. Please enter a recipient or newsgroup in the addressing area."

However, Thunderbird has multiple affordances to trigger sending the message that may not be able to provide visual feedback of their own, like hot-keys.  We have a button that can provide visual feedback.  I think the easiest thing for us to do, and which avoids adding more strings, is to disable the send button.  But this is a Casey call. Casey?
Flags: needinfo?(kyee)
It appears that only gmail exhibits this issue.  IMAP/Hotmail both give an error message stating that Sending Email failed and will bring you back to the email message you are composing.

When composing the email through gmail, the email goes through and sends it.  In the Sent Items, you see the blank email.  In today's build, the email is not received in the Inbox.  It may be a gaia issue?  As it doesn't actually seem to send the email, otherwise I would see it in the inbox of the gmail account.
Keywords: qawanted
(In reply to Andrew Sutherland (:asuth) from comment #9)

> We have a button that can provide visual feedback.  I think the easiest
> thing for us to do, and which avoids adding more strings, is to disable the
> send button.  But this is a Casey call. Casey?

I think that's a pretty reasonable way to avoid this bug and we can also reduce the effort of showing warning prompt. But except from this issue, we still need to find out the root cause of no error callback from gmail. The error in callback is still null if the address is invalid while using gmail account.
(In reply to Steve Chung from comment #11)
> I think that's a pretty reasonable way to avoid this bug and we can also
> reduce the effort of showing warning prompt. But except from this issue, we
> still need to find out the root cause of no error callback from gmail. The
> error in callback is still null if the address is invalid while using gmail
> account.

We just switched gmail back to IMAP from ActiveSync, so this is unlikely to be a problem anymore.  Specifically, I expect the SMTP server to freak out and generate errors when we try and send without a recipient.  The gmail activesync implementation is probably just buggy and assumes (fairly reasonably) that no one would be so crazy as to try and send a message without any recipients.
Hi Casey, I disable send button if no recipient. Please feel free to give comment if this patch does not fit your design, thanks.
Attachment #682379 - Flags: review?(bugmail)
I retested this with the new IMAP Gmail, and I do not get an error message when I try to send an empty email.
Comment on attachment 682379 [details]
Patch for send button disable if no addres input

r=asuth with request fix on the pull request.
Attachment #682379 - Flags: review?(bugmail) → review+
Pull request is fixed, thanks for the reminder.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: needinfo?(kyee)
Status: RESOLVED → VERIFIED
verified on Unagi build 20121231070201 send button is grayed-out when you trying to send email without filling out any fields
verified in 20130101 pvt build for unagi
Hardware: x86 → ARM
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: