810178 - MMI Codes do not work when no SIM Card is inserted

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Daniel Coloma:dcoloma]

The MMI codes such as *#06# should work even without a SIM inserted, as they do not require cellular connectivity.

STR:

 - Open the dialer in a device without a SIM Card
 - Dial *#06#

RESULT: Nothing happens

EXPECTED RESULT: The device IMEI is returned.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Germán, can you take a look at this issue, please?

Comment 2

[David Scravaglieri [:scravag]]

Is it mandatory for certification ?

Comment 3

[Beatriz Rodríguez [:brg]]

This is Mandatory for certification. 
The reason of the high importance level is that devices are registered by operator when they are sold. In some countries, Operator subsidise the devices sold. 
When a shop assintant sell the product under the subsidise of an operator, then the shop assistant should ask for the money back to the operator. The only way they use to track the devices sold and avoid any issue is the IMEI.
Pleas keep in mind this key is very important.

Then in the shop, the shop assistant will turn the device on to trackle the IMEI. He will not include any SIM card, because the device is already sold and he cannot waste time :-( and will use MMI code to read the IMEI.

Sorry for this long speech, but I want to emphasize that there is a good reason behind this request.

Comment 4

[Tony Chung [:tchung]]

certification required, blocking, p1

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

I have it solved :-) Just waiting for https://github.com/mozilla-b2g/gaia/pull/6404 to land. ASA it does, I will prepare a new PR for this bug ;-)

Comment 6

[Alex Keybl [:akeybl]]

Marking for C2, given this meets the criteria of known P1/P2 blocking-basecamp+ bugs at the end of C1.

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

PR sent: https://github.com/mozilla-b2g/gaia/pull/6556

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR diff file.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 684000 [details] [diff] [review]
Associated PR diff file.

You don't need to ask for approval-gaia-master if the bug is set as blocking-basecamp+

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 684000 [details] [diff] [review]
Associated PR diff file.

Review of attachment 684000 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by review...

::: apps/communications/dialer/js/dialer.js
@@ +155,4 @@
>      });
>    }
>  
> +  function isMMI(number) {

This code is a dup of the one at [1]. I would prefer not to duplicate all this expensive parsing process and just look for '*' and/or '#' characters, as we've been doing so far.

[1]http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#2266

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Hi :ferjm :) Please, contact me via Skype to discuss about this ;-) Thanks!

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

After commenting it with :ferjm as well as with Beatriz (due to https://bugzilla.mozilla.org/show_bug.cgi?id=813679), we decided the following: A valid USSD/MMI code is any 'number' starting with #, or starting with * and with no * or # at the end. The USSD/MMI codes will be sent even if there is no SIM card available. In case of airplane mode, the USSD/MMI codes won't be sent either the phone number dialed.

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated new PR diff file.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 14

[Germán Toro del Valle (:gtorodelvalle)]

Updated PR link (the same as before): https://github.com/mozilla-b2g/gaia/pull/6556

Comment 15

[Fernando Jiménez Moreno [:ferjm]]

(In reply to gtorodelvalle from comment #12)
> After commenting it with :ferjm as well as with Beatriz (due to
> https://bugzilla.mozilla.org/show_bug.cgi?id=813679), we decided the
> following:

Thanks Germán. I am afraid that I might not explained myself properly.

> A valid USSD/MMI code is any 'number' starting with #, or
> starting with * and with no * or # at the end. 

This is not correct. Just look for * and/or # in the dial number. Nothing else. If the dial number contains * and/or #, you have to call |sendMMI(dialNumber)|.

>The USSD/MMI codes will be
> sent even if there is no SIM card available.

Exactly! This is the purpose of this bug :)

>In case of airplane mode, the
> USSD/MMI codes won't be sent either the phone number dialed.

I am afraid that you would need to send the MMI even if the phone is in airplane mode. Note that there are MMI codes associated to functionality that does not require any kind of radio activity (get the IMEI, for example). MMI codes that triggers radio services would fail in this case, but that is totally expected.

Thanks for all the work Germán and sorry for the misunderstanding!

Comment 16

[Germán Toro del Valle (:gtorodelvalle)]

No, no, sorry from my side! Definitely we understand much better each other in English than in Spanish or Andalusian :-p Implementing it right now!

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 684380 [details] [diff] [review]
Associated new PR diff file.

German you don't need the approval gaia master when the bug is bb+

Thanks.

Comment 18

[Jose Manuel Cantera]

German, is better to put a link to the PR in GH as attachment. See for example bug 813490

Comment 19

[Germán Toro del Valle (:gtorodelvalle)]

PR landed in Gaia ;-)