810227 - [FTU] Card view should not be able to launch

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[John Shih]

## Environment :
Otoro phone, build 2012-11-09
Build info: 
* gaia master: revision= a9e28710cb2f1f68576986c5e348d990a2514ee0
* gecko aurora revision= 6735d6d13751

## Repro :
1. Flash the phone
2. Unlock the phone, FTU app will be launched
3. In the FTU app, long press on home button

## Expected:
* Nothing happen

## Actual:
* Card view will be launch, I even can scroll up to kill the FTU app

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

I recalls that android FTU prevents the user from pressing home or holding home button.
Window Manager has a workaround about preventing home button event to occur when ftu is running, maybe we need the same logic in the cards view.

Comment 2

[David Scravaglieri [:scravag]]

Does ftu is mandatory to be run ?

Comment 3

[Josh Carpenter [:jcarpenter]]

Good catch, John. You are correct. We need to disable the Task Manager and Home buttons when the user is in the FTE (both the Setup, and the subsequent Tutorial app).

Comment 4

[David Scravaglieri [:scravag]]

Does it affect the device configuration in any way ?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to dscravaglieri from comment #2)
> Does ftu is mandatory to be run ?

It is. I would say this is blocking just because this is the first interaction the user has with the device so it should not have buggy behavior. Renoming.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to dscravaglieri from comment #4)
> Does it affect the device configuration in any way ?

If we don't fix this,
the user could kill/close FTU in card view when the FTU is still running, and cannot find FTU anywhere until he 'factory resets' the phone.

Comment 7

[Borja Salguero [:borjasalguero]]

Some comments. It's true that 'card-view' during 'FTU' should not be launch, so we should 'prevent' the 'holdhome' event. On the other hand, killing 'FTU' doesnt mean that you are not going to see it again, due to FTU is over ONLY if the whole process is over (if at the end you click on 'Let's go'). 
IMHO I think that this bug should be bb+ in order to fix it asap. 
[:vivien] 'holdhome' event is currently being used in some parts of the code, any suggestion for fixing it? Because I think that it's not enough with 'preventing the default' behaviour...

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Borja Salguero [:borjasalguero] from comment #7)
> Some comments. It's true that 'card-view' during 'FTU' should not be launch,
> so we should 'prevent' the 'holdhome' event. On the other hand, killing
> 'FTU' doesnt mean that you are not going to see it again, due to FTU is over
> ONLY if the whole process is over (if at the end you click on 'Let's go'). 
> IMHO I think that this bug should be bb+ in order to fix it asap. 
> [:vivien] 'holdhome' event is currently being used in some parts of the
> code, any suggestion for fixing it? Because I think that it's not enough
> with 'preventing the default' behaviour...

event.preventDefault() should be enough. Other codes needs to check for event.defaultPrevented and do nothing if that the case.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia Triage : -

Discussion points:
Even though FTU appears only after flashing or reseting the device, all the options should be available to the end user to manually do so, rather than being forced to go through the FTU each time.  Also to note, for a first time user, they most likely wouldn't know to hold the home key down.  This seems like an edge case.

Comment 10

[Josh Carpenter [:jcarpenter]]

> On the other hand, killing 'FTU' doesnt mean that you are not going to see
> it again, due to FTU is over ONLY if the whole process is over (if at the
> end you click on 'Let's go'). 

Good to know, but that is also problematic. So I skip the FTE (intentionally or accidentally) and then am presented with it the next time I use the device? That is very unexpected behavior.

> This seems like an edge case.

Respectfully disagree. Remember that we're also disabling the Home button during the FTE. What is a common reaction to a button not working? Pressing it longer. And poof, suddenly you're in the Task Manager. Baffling for novice users, with non-trivial chance of killing the FTE entirely via swipe to dismiss. We should close this loophole. Vivien already outlined the method. Re-nom'ing.

Comment 11

[Borja Salguero [:borjasalguero]]

Attachment: PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 12

[Borja Salguero [:borjasalguero]]

Solved implicitly with the workaround fixed in #810229 ! Closing!

Comment 13

[John Shih]

verified on 2012-11-20 unagi
gaia master : 53d1e5cf7b805a6e83a070de5b01fb28b8558380
mozilla-aurora : b3950b0ad29a