Port Bio 1772 - IRC account disconnects on receiving action messages containing line breaks

RESOLVED FIXED in Thunderbird 19.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: florian, Assigned: clokep)

Tracking

Trunk
Thunderbird 19.0

Thunderbird Tracking Flags

(thunderbird17 fixed, thunderbird18 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 680082 [details] [diff] [review]
Fix

Filing a BMO bug to request approval on the patch. I think we want to take this patch for Thunderbird 17.

Approval request comments:
- limited risk: very trivial change, replacing . with [\s\S] in a regexp to also match the \n character.
- Unit test included in the patch.
- impact: possible security issue if this bug is abused (it's possible to trigger this bug remotely to cause an IRC account connected with Thunderbird to be disconnected.)
Attachment #680082 - Flags: approval-comm-beta?
Attachment #680082 - Flags: approval-comm-aurora?
(Reporter)

Comment 1

5 years ago
https://hg.mozilla.org/comm-central/rev/8f7b52bb7e76
Assignee: nobody → clokep
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 19.0
Attachment #680082 - Flags: approval-comm-beta?
Attachment #680082 - Flags: approval-comm-beta+
Attachment #680082 - Flags: approval-comm-aurora?
Attachment #680082 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/68fceec2149b
https://hg.mozilla.org/releases/comm-beta/rev/82fcebdc15e2
status-thunderbird17: --- → fixed
status-thunderbird18: --- → fixed
(Reporter)

Comment 3

5 years ago
(In reply to Mark Banner (:standard8) from comment #2)
> https://hg.mozilla.org/releases/comm-aurora/rev/68fceec2149b
> https://hg.mozilla.org/releases/comm-beta/rev/82fcebdc15e2

Actually, the links you wanted to paste are:
https://hg.mozilla.org/releases/comm-aurora/rev/7ecd8dae0053
https://hg.mozilla.org/releases/comm-beta/rev/161c4dc3487c
(Reporter)

Updated

4 years ago
See Also: → bug 955204
You need to log in before you can comment on or make changes to this bug.