Last Comment Bug 810330 - Port Bio 1772 - IRC account disconnects on receiving action messages containing line breaks
: Port Bio 1772 - IRC account disconnects on receiving action messages containi...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 19.0
Assigned To: Patrick Cloke [:clokep]
:
Mentors:
https://bugzilla.instantbird.org/show...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-09 08:01 PST by Florian Quèze [:florian] [:flo]
Modified: 2013-12-30 05:31 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
Fix (3.75 KB, patch)
2012-11-09 08:01 PST, Florian Quèze [:florian] [:flo]
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Florian Quèze [:florian] [:flo] 2012-11-09 08:01:08 PST
Created attachment 680082 [details] [diff] [review]
Fix

Filing a BMO bug to request approval on the patch. I think we want to take this patch for Thunderbird 17.

Approval request comments:
- limited risk: very trivial change, replacing . with [\s\S] in a regexp to also match the \n character.
- Unit test included in the patch.
- impact: possible security issue if this bug is abused (it's possible to trigger this bug remotely to cause an IRC account connected with Thunderbird to be disconnected.)
Comment 1 Florian Quèze [:florian] [:flo] 2012-11-09 09:17:07 PST
https://hg.mozilla.org/comm-central/rev/8f7b52bb7e76

Note You need to log in before you can comment on or make changes to this bug.