810330 - Port Bio 1772 - IRC account disconnects on receiving action messages containing line breaks

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

Attachment: Fix

Filing a BMO bug to request approval on the patch. I think we want to take this patch for Thunderbird 17.

Approval request comments:
- limited risk: very trivial change, replacing . with [\s\S] in a regexp to also match the \n character.
- Unit test included in the patch.
- impact: possible security issue if this bug is abused (it's possible to trigger this bug remotely to cause an IRC account connected with Thunderbird to be disconnected.)

Comment 1

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/8f7b52bb7e76

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/68fceec2149b
https://hg.mozilla.org/releases/comm-beta/rev/82fcebdc15e2

Comment 3

[Florian Quèze [:florian]]

(In reply to Mark Banner (:standard8) from comment #2)
> https://hg.mozilla.org/releases/comm-aurora/rev/68fceec2149b
> https://hg.mozilla.org/releases/comm-beta/rev/82fcebdc15e2

Actually, the links you wanted to paste are:
https://hg.mozilla.org/releases/comm-aurora/rev/7ecd8dae0053
https://hg.mozilla.org/releases/comm-beta/rev/161c4dc3487c