try_spidermonkey jobs are running on non-try slaves

RESOLVED INVALID

Status

P2
normal
RESOLVED INVALID
6 years ago
7 months ago

People

(Reporter: catlee, Assigned: sfink)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [try])

Attachments

(5 attachments)

(Reporter)

Description

6 years ago
"Linux x86-64 try leak test spidermonkey_try-rootanalysis build" is happening on non-try slaves...also on non-try masters.
(Reporter)

Comment 1

6 years ago
Oh, and the jobs from different try pushes are getting merged together...which makes the results pretty meaningless I think.
Assignee: nobody → nthomas
Priority: -- → P2
(Assignee)

Comment 2

6 years ago
Created attachment 680859 [details] [diff] [review]
Cross-check builders and slaves to make sure the security levels do not get mixed up

This should really be carved up in the opposite order, but this adds a (failing) test to check that no access level 1 jobs are going to level 3 slaves.
Attachment #680859 - Flags: review?(catlee)
(Assignee)

Updated

6 years ago
Assignee: nthomas → sphink
(Assignee)

Comment 3

6 years ago
Created attachment 680861 [details] [diff] [review]
Record the access_level required for builders, for cross-checking security settings

buildbotcustom portion of the access checks
Attachment #680861 - Flags: review?(catlee)
(Assignee)

Updated

6 years ago
Attachment #680859 - Attachment is obsolete: true
Attachment #680859 - Flags: review?(catlee)
(Assignee)

Comment 4

6 years ago
Created attachment 680862 [details] [diff] [review]
Use the spidermonkey slaves passed in as a parameter rather than pulling them from the platform_config

Fix spidermonkey builds to use appropriate slaves, part 1.
Attachment #680862 - Flags: review?(catlee)
(Assignee)

Comment 5

6 years ago
Created attachment 680863 [details] [diff] [review]
Pass in the appropriate slaves to the spidermonkey builds
Attachment #680863 - Flags: review?(catlee)
(Assignee)

Comment 6

6 years ago
(In reply to Chris AtLee [:catlee] from comment #0)
> "Linux x86-64 try leak test spidermonkey_try-rootanalysis build" is
> happening on non-try slaves...also on non-try masters.

non-try masters? Oh, the masters are segregated too?

Hm... so my access_level stuff is probably junk.

How are things separated across masters? Are production_localconfig.py and try_localconfig.py supposed to only generate the relevant builders, but both go through scheduler_master.cfg?

Then how are the non-spidermonkey projects avoiding the try scheduler master? Ugh, maybe I don't want to know.

Well, assuming my suppositions are correct, patch upcoming...
(Assignee)

Comment 7

6 years ago
Created attachment 680891 [details] [diff] [review]
split up projects by try and non-try

Thanks to nthomas for explaining the various master types to me, and which config file corresponds to each. With my shiny new understanding, this patch seems reasonable.

In brief, so I have it written down somewhere electronically:

buildbot starts up a master using buildbot.tac
 -> loads master.cfg
    - one of 3 roles: builder, scheduler, tests
    - symlink to {builder,scheduler,tests}_master.cfg
 -> loads master_localconfig.py
    - for builder|scheduler: either try or non-try
      - symlink {try,build}_localconfig.py
    - for tests: always symlink to tests_localconfig.py
 -> loads config.py
    - either mozilla/config.py (for builders + schedulers)
      or mozilla-tests.py (for tests)
 -> loads localconfig.py
    - symlink to {production,preproduction,staging}_config.py
    - (separate for tests and build/scheduler)

...except that master.cfg actually loads config.py *before* master_localconfig.py, which means that you can use the stuff defined in config.py within the code of master_localconfig.py (important for this patch!), even though the import of config.py from master_localconfig.py would suggest otherwise (and that import doesn't really do anything.)

I will note that neither "local" nor "config" really adds much when you're already within a module named "buildbot-configs", and using "build" in both {try,build}_localconfig.py is rather confusing when there's also {builder,scheduler,tests}_master.cfg. </whine>
Attachment #680891 - Flags: review?(catlee)
(Assignee)

Comment 8

6 years ago
(In reply to Chris AtLee [:catlee] from comment #1)
> Oh, and the jobs from different try pushes are getting merged
> together...which makes the results pretty meaningless I think.

I haven't addressed this yet. Ok, I haven't even looked to see what this means, given that I know the jobs are failing due to yet another $PATH problem anyway.
(Assignee)

Comment 9

6 years ago
Comment on attachment 680859 [details] [diff] [review]
Cross-check builders and slaves to make sure the security levels do not get mixed up

Argh, I keep naming my patches the same and bzexport makes them clobber each other.
Attachment #680859 - Attachment is obsolete: false
Attachment #680859 - Flags: review?(catlee)
(Reporter)

Updated

6 years ago
Attachment #680891 - Flags: review?(catlee) → review+
(Assignee)

Updated

6 years ago
Attachment #680891 - Flags: checked-in+
(Assignee)

Comment 12

6 years ago
Turns out that last patch cannot be landed separately, because it triggers the try build master to start generating jobs for production slaves, which it doesn't know about. I guess all of the non-test patches need to land together.

http://hg.mozilla.org/build/buildbot-configs/rev/18de55f7ec08 - backed out f24e3b0a81ba
http://hg.mozilla.org/build/buildbot-configs/rev/531a24d02699 - backed out changeset 40fd8b9ca7b0 (bug 810374)
(Reporter)

Comment 13

6 years ago
Disabled the jobs completely until we can get this fixed up:

http://hg.mozilla.org/build/buildbot-configs/rev/b6405077b019
(Assignee)

Comment 14

6 years ago
Comment on attachment 680891 [details] [diff] [review]
split up projects by try and non-try

I backed out the patch (and the followup fix), so now nothing is checked in.

aki clued me into test-masters.sh, which passes with all of these patches applied.
Attachment #680891 - Flags: checked-in+
(Assignee)

Comment 15

6 years ago
I think everything in this bug has been handled in separate bugs now.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
Product: mozilla.org → Release Engineering
(Assignee)

Comment 16

5 years ago
Comment on attachment 680859 [details] [diff] [review]
Cross-check builders and slaves to make sure the security levels do not get mixed up

Garbage collecting dead review requests.
Attachment #680859 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Attachment #680861 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Attachment #680862 - Flags: review?(catlee)
(Assignee)

Updated

5 years ago
Attachment #680863 - Flags: review?(catlee)
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.