Closed Bug 810379 Opened 9 years ago Closed 10 months ago

ShapedButton drawing steals frames from the tabs animation

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: lucasr, Unassigned)

References

Details

I noticed that several frames at the beginning of the tabs tray animation are dropped because of the custom drawing code in ShapedButton. Need to profile and find out where ShapedButton is being slow here.
I found that onMeasure() is called many times, and we are unnecessarily create paths when the size doesn't change. I've filed a bug 814224 to work on that. That might help it. But how do I find that frames are dropped?
Depends on: 814224
If you want quickly check that, you can simply print the time (AnimationUtils.currentAnimationTimeMillis()) on each frame in PropertyAnimator. The framerate (time between each draw) should be roughly constant.

Back when I was testing the new PropertyAnimator implementation, I noticed that the first several frames of the animation to open the tabs tray were being dropped. Doesn't happen on the closing animation though.

This might not be related to onMeasure() calls. Maybe it's more about the performance of drawing the pressed state in and out.
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.