When Video fails to record, cant discard overlay

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: daleharvey, Assigned: daleharvey)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: QARegressExclude)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Assignee: nobody → dale
blocking-basecamp: --- → ?
(Assignee)

Comment 1

6 years ago
Created attachment 680821 [details]
Switch recoverable error to dialog instead of overlay messages

Preemptively fixed since I would expect this to be blocking+ 

There was some changes previously that made it not clear whether the use can continue after getting an overlay, overlays are now blocking whereas error messages should be dialogs the user can continue after.
Attachment #680821 - Flags: review?(dflanagan)
Comment on attachment 680821 [details]
Switch recoverable error to dialog instead of overlay messages

r+ if you address the comments on github
Attachment #680821 - Flags: review?(dflanagan) → review+
blocking-basecamp: ? → +
Priority: -- → P1
Priority: P1 → P2
(Assignee)

Comment 3

6 years ago
Merged in https://github.com/mozilla-b2g/gaia/commit/1b691567001228ca6d54b5c58eb6b6dac660e7b2

r=davidflanagan
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.