Closed Bug 810658 Opened 12 years ago Closed 12 years ago

Using a svg image for the contentURL of a widget dnw

Categories

(Add-on SDK Graveyard :: General, defect, P2)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

(
URL
)

Details

Attachments

(1 file)

Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/655
355 bytes, text/html
irakli
: review+
Details
This was mentioned in the mailing list, there is some doc.body dne error.
Summary: Using a svg document is a panel dnw → Using a svg image is a panel dnw
Attachment #681326 - Flags: review?(rFobic)
Assignee: nobody → evold
Summary: Using a svg image is a panel dnw → Using a svg image for the contentURL of a widget dnw
Comment on attachment 681326 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/655 Looks good, but pull request requires update.
Attachment #681326 - Flags: review?(rFobic) → review+
Also as Wes has pointed out in IRC I've missed the fact that url in one of the tests referred to a wrong url. Please make sure to fix that and run tests before landing!
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1ed9c36e1de77c074db34f2bf853e9031342d0ba Merge pull request #655 from erikvold/810658 Fix Bug 810658: Using a svg image for the contentURL of a widget does not work r=@gozala
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: