Closed
Bug 81069
Opened 25 years ago
Closed 24 years ago
Add <title> tag when blank document is created in composer
Categories
(SeaMonkey :: Composer, defect, P3)
SeaMonkey
Composer
Tracking
(Not tracked)
VERIFIED
INVALID
mozilla0.9.5
People
(Reporter: shrir, Assigned: Brade)
Details
(Whiteboard: EDITORBASE 1 day)
Attachments
(1 file)
|
785 bytes,
patch
|
Details | Diff | Splinter Review |
Launch a blank page in composer, view source.
Observe that the '<title></title>' tag is not included unless u try to
save/save the file
| Assignee | ||
Updated•25 years ago
|
Hardware: PC → All
| Assignee | ||
Comment 3•25 years ago
|
||
Does adding something like this around line 1780 in editor.js work?
// add a title to new pages
if (headelement)
{
element = domdoc.createElement("title");
if (element)
headelement.appendChild(element);
}
| Assignee | ||
Comment 4•25 years ago
|
||
-->brade
I have the fix for this
Assignee: rcassin → brade
Target Milestone: mozilla1.0 → mozilla0.9.5
Kathy, good, can you attach a patch (after you finish driving home that is :-)
| Assignee | ||
Updated•25 years ago
|
Component: Editor: Core → Editor: Composer
| Assignee | ||
Comment 6•24 years ago
|
||
| Assignee | ||
Comment 7•24 years ago
|
||
please disregard the last part of that patch (part of another bug which I will
not be checking in as part of this fix).
Status: NEW → ASSIGNED
Does the method you are adding that code to (EditorSetDefaultPrefsAndDoctype())
get called even when we're loading existing documents that may already have a
title? If so, wouldn't you be adding a 2nd title under head?
Comment 9•24 years ago
|
||
Kin: No, that shouldn't happen 'cause of this code above the new code:
/* only set default prefs for new documents */
if ( !newDoc )
return;
BUT: In my debug build as of 9/20/01, when I switch to HTML Source mode, I
already *do* see <title></title> in the source, thus the new code *does* add a
second title!
| Assignee | ||
Comment 10•24 years ago
|
||
interesting... there are now two title tags in my build. That is what I get for
holding on to this patch for so long. I'm guessing that the dtd or something
else is forcing the creation of the title tag now.
I'm going to resolve this bug as invalid since we no longer seem to need to add
the title tag.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → INVALID
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•