Infinite loop for parsing metadata of a mp4 file with zero size

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sinker, Assigned: sinker)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 680495 [details] [diff] [review]
make MediaStreamSource::readAt() aware of EOF

If you push an empty MP4 file (0 byte) to the device, gecko would run into an infinite loop for parsing meta data of the container.  Root cause is MediaStreamSource::readAt() is not aware of EOF of the container.
(Assignee)

Updated

6 years ago
Blocks: 798448
Thanks Thinker! Is this patch ready for review?
(Assignee)

Updated

6 years ago
Attachment #680495 - Flags: review?(chris.double)

Updated

6 years ago
blocking-basecamp: --- → ?

Updated

6 years ago
blocking-basecamp: ? → +

Updated

6 years ago
Assignee: nobody → tlee

Updated

6 years ago
Attachment #680495 - Flags: review?(chris.double) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 683902 [details] [diff] [review]
check EOF to avoid infinite looping when parsing MP4

r=doublec
Attachment #680495 - Attachment is obsolete: true
Attachment #683902 - Flags: review+

Comment 3

6 years ago
Whats the status here? We need this _urgently_ landed.

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/414dab54c904

Can we get a test for this?
Flags: in-testsuite?
Keywords: checkin-needed

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/414dab54c904
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/0a53935f0343
https://hg.mozilla.org/releases/mozilla-beta/rev/a55eb398a235
status-firefox18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed
You need to log in before you can comment on or make changes to this bug.