810743 - XPCWrappedNative shouldn't clobber explicit exceptions set on the context

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

I really hesitate to dive into this, but this looks so dumb and so easy to fix.

Comment 1

[Bobby Holley (:bholley)]

Attachment: First check for pending exceptions, _then_ examine the invoke result. v1

Comment 2

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=4efb87473d01

Comment 3

[Bobby Holley (:bholley)]

looks green.

Comment 4

[Josh Matthews [:jdm]]

Oh my. I wonder if this has any effect on bug 503244?

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 680504 [details] [diff] [review]
First check for pending exceptions, _then_ examine the invoke result. v1

I'm holding my breath. Touching XPConnect exception handling has always been... exciting. Here's to hoping that try has changed all of that :-/

Comment 6

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d13fb8bd7f5

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9d13fb8bd7f5