810760 - Don't <br /> jetpack results

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

This is, of course, madness, but it's the multidirectional reverse-engineered madness we live in.

Tinderbox was a giant table that nobody would touch, so to avoid widening the table cells, buildbot summarized results with "TinderboxPrint: %s<br/>%s\n" (or %s:%s, because a foolish constancy etc.).

tbpl learned that it could dig out results by looking for /(.*)(\:|<br\/>)(.*)/.

Jetpack's results, rather than having the invalid <br/>, have the invalid but typically, at least at the time, ignored by validators <br />. As a result, given the right screen width and tbpl's use of columns for the scrape, they display as

* s: talos-r3-fed-071                                         5712/0
* jetpack

because tbpl doesn't recognize them as results, and doesn't strip them down into "jetpack: 5712/0" like it would for <br/>.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: buildbotcustom

Comment 2

[Phil Ringnalda (:philor)]

Attachment: tools

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 680534 [details] [diff] [review]
tools

http://hg.mozilla.org/build/tools/rev/e2cdcfdc5df4

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 680533 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/3bada48fec78

Comment 5

[Phil Ringnalda (:philor)]

This is in production now.

Comment 6

[Phil Ringnalda (:philor)]

Okay, thanks!