810995 - Remove hgweb link from "thank you for your try submission" email

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

The try submission emails look like:
{
Thanks for your try submission (http://hg.mozilla.org/try/pushloghtml?changeset=909200e6d543).  It's the best!

Watch https://tbpl.mozilla.org/?tree=Try&rev=909200e6d543 for your results to come in.

Builds and logs will be available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-909200e6d543.

This directory won't be created until the first builds are uploaded, so please be patient.
}

Roughly 50% of the time, I end up using the first link in the email, even though it isn't what I want, due to the wrapping & the links looking pretty similar.

For Try pushes, 99.9% of people will just be wanting to see the TBPL results (and the hgweb links are available on TBPL anyway), so to reduce confusion we should just remove the hgweb link. 

With a few misc cleanups, I propose something like:

{
Thank you for your try submission.  It's the best!

Watch TBPL for your results to come in:
https://tbpl.mozilla.org/?tree=Try&rev=909200e6d543

Once completed, builds and logs will be available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-909200e6d543
}

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 680686 [details] [diff] [review]
Patch v1

Review of attachment 680686 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, sounds good to me.

Comment 3

[Ed Morley [:emorley]]

Thank you for the review :-)

https://hg.mozilla.org/build/buildbotcustom/rev/cffc8d2e27ab

Comment 4

[Ed Morley [:emorley]]

In production :-)

eg:
{
Thank you for your try submission. It's the best!

Results will be displayed on TBPL as they come in:
https://tbpl.mozilla.org/?tree=Try&rev=7a214a0f3464

Once completed, builds and logs will be available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-7a214a0f3464
}