811016 - inconsistent signature for TerminateAllProcesses

Status: RESOLVED DUPLICATE of bug 809276

(Testing :: Talos, defect)

Description

[Jeff Hammel]

(talos)│grep 'TerminateAllProcesses' talos/*.py
talos/ffprocess_linux.py:    def TerminateAllProcesses(self, timeout,
process_names):
talos/ffprocess_mac.py:    def TerminateAllProcesses(self, timeout,
process_names):
talos/ffprocess.py:        terminate_result =
self.TerminateAllProcesses(browser_wait, *processes_to_kill)
talos/ffprocess_remote.py:    def TerminateAllProcesses(self, timeout,
*process_names):
talos/ffprocess_win32.py:    def TerminateAllProcesses(self, timeout,
process_names):

Note that ffprocess_remote.py uses *process_names while the others
just use process_names.  This was introduced in
http://hg.mozilla.org/build/talos/rev/3d6510e7c2dd

It would be nice if someone found the time to note these methods in
the ABC in ffprocess.py and e.g. `raise NotImplementedError("Abstract
method")`

Comment 1

[Jeff Hammel]

I'll probably take this along with https://bugzilla.mozilla.org/show_bug.cgi?id=809276 . 

I'm inclined to make everything use *args vs args.  :jmaher, have any opposition?

Comment 2

[Jeff Hammel]

I'm also inclined to combine the ffprocess_linux and ffprocess_mac methods though probably not in this bug

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

whatever we do we need to do it fast as talos is broken.

Comment 4

[Jeff Hammel]

Done in patch on https://bugzilla.mozilla.org/show_bug.cgi?id=809276

Comment 5

[Jeff Hammel]

taken with fix for bug 809276