Closed Bug 811058 Opened 7 years ago Closed 7 years ago
Monkey: Add incremental barriers to addprop ICs
IonMonkey can overwrite shape values (via addprop ICs) without invoking a GC barrier.
Sounds memory-corruption-y. Feel free to downgrade as necessary. Marking for tracking because there's a patch.
actually valid patch
Attachment #680815 - Flags: review?(wmccloskey) → review+
Comment on attachment 680815 [details] [diff] [review] v2 [Security approval request comment] How easily can the security issue be deduced from the patch? Not easily. Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem? No. Which older supported branches are affected by this flaw? Firefox 18. If not all supported branches, which bug introduced the flaw? IonMonkey. Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be? This patch should apply to Firefox 18. How likely is this patch to cause regressions; how much testing does it need? Very little.
Attachment #680815 - Flags: sec-approval?
Comment on attachment 680815 [details] [diff] [review] v2 sec-approval+
Attachment #680815 - Flags: sec-approval? → sec-approval+
Duplicate of this bug: 815727
Is this ready to be landed on 18 and 19?
Comment on attachment 680815 [details] [diff] [review] v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): IonMonkey User impact if declined: Potential security-critical bug Testing completed (on m-c, etc.): Yes Risk to taking this patch (and alternatives if risky): Very little String or UUID changes made by this patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/d84d3184ed07 This didn't apply to beta, so I didn't push it there.
You need to log in before you can comment on or make changes to this bug.