Closed Bug 811058 Opened 7 years ago Closed 7 years ago

IonMonkey: Add incremental barriers to addprop ICs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20
Tracking Status
firefox17 --- unaffected
firefox18 + fixed
firefox19 + fixed
firefox20 --- fixed
firefox-esr10 --- unaffected
firefox-esr17 --- unaffected

People

(Reporter: dvander, Assigned: dvander)

References

Details

(Keywords: csectype-uaf, regression, sec-high, Whiteboard: [adv-main18-])

Attachments

(1 file, 1 obsolete file)

IonMonkey can overwrite shape values (via addprop ICs) without invoking a GC barrier.
Attached patch fix (obsolete) — Splinter Review
Attachment #680754 - Flags: review?(wmccloskey)
Sounds memory-corruption-y. Feel free to downgrade as necessary. Marking for tracking because there's a patch.
Attached patch v2Splinter Review
actually valid patch
Attachment #680754 - Attachment is obsolete: true
Attachment #680754 - Flags: review?(wmccloskey)
Attachment #680815 - Flags: review?(wmccloskey)
Attachment #680815 - Flags: review?(wmccloskey) → review+
Comment on attachment 680815 [details] [diff] [review]
v2

[Security approval request comment]
How easily can the security issue be deduced from the patch?

Not easily.

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?

No.

Which older supported branches are affected by this flaw?

Firefox 18.

If not all supported branches, which bug introduced the flaw?

IonMonkey.

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?

This patch should apply to Firefox 18.

How likely is this patch to cause regressions; how much testing does it need?

Very little.
Attachment #680815 - Flags: sec-approval?
Comment on attachment 680815 [details] [diff] [review]
v2

sec-approval+
Attachment #680815 - Flags: sec-approval? → sec-approval+
https://hg.mozilla.org/mozilla-central/rev/6bc3cd4a52ec
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Is this ready to be landed on 18 and 19?
Comment on attachment 680815 [details] [diff] [review]
v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): IonMonkey
User impact if declined: Potential security-critical bug
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): Very little
String or UUID changes made by this patch:
Attachment #680815 - Flags: approval-mozilla-beta?
Attachment #680815 - Flags: approval-mozilla-aurora?
Attachment #680815 - Flags: approval-mozilla-beta?
Attachment #680815 - Flags: approval-mozilla-beta+
Attachment #680815 - Flags: approval-mozilla-aurora?
Attachment #680815 - Flags: approval-mozilla-aurora+
Whiteboard: [adv-main18-]
Group: core-security
You need to log in before you can comment on or make changes to this bug.