811058 - IonMonkey: Add incremental barriers to addprop ICs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

IonMonkey can overwrite shape values (via addprop ICs) without invoking a GC barrier.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[Andrew McCreight [:mccr8]]

Sounds memory-corruption-y. Feel free to downgrade as necessary. Marking for tracking because there's a patch.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v2

actually valid patch

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 680815 [details] [diff] [review]
v2

[Security approval request comment]
How easily can the security issue be deduced from the patch?

Not easily.

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?

No.

Which older supported branches are affected by this flaw?

Firefox 18.

If not all supported branches, which bug introduced the flaw?

IonMonkey.

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?

This patch should apply to Firefox 18.

How likely is this patch to cause regressions; how much testing does it need?

Very little.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 680815 [details] [diff] [review]
v2

sec-approval+

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6bc3cd4a52ec

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6bc3cd4a52ec

Comment 9

[Andrew McCreight [:mccr8]]

Is this ready to be landed on 18 and 19?

Comment 10

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 680815 [details] [diff] [review]
v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): IonMonkey
User impact if declined: Potential security-critical bug
Testing completed (on m-c, etc.): Yes
Risk to taking this patch (and alternatives if risky): Very little
String or UUID changes made by this patch:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d84d3184ed07

This didn't apply to beta, so I didn't push it there.

Comment 12

[David Anderson [:dvander] - inactive, e-mail if emergency]

https://hg.mozilla.org/releases/mozilla-beta/rev/70d6b6426802