811217 - EventNameType_SMIL seems to be wrong

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's 0x16, whereas I'd expect 0x10...  But maybe things are depending on it including the EventNameType_SVGGraphic bit (likely) and the EventNameType_XUL bit (very unlikely)?

Comment 1

[Robert Longson [:longsonr]]

It's just wrong. 0x10 is right. r=longsonr if you change it.

Comment 2

[Olli Pettay [:smaug]]

But should SVGAnimationElement support the onfoo attributes other svg elements do?
I think it should, for consistency.

Comment 3

[Robert Longson [:longsonr]]

They need to support this: http://www.w3.org/TR/SVG/script.html#AnimationEvents

Comment 4

[Olli Pettay [:smaug]]

I'm just worried that since we've shipped effectively with
EventNameType_SVGGraphic | EventNameType_SMIL
limiting to EventNameType_SMIL might break something.

What do other browsers do here?

Comment 5

[Robert Longson [:longsonr]]

Note that Webkit doesn't support animation events at all.

Comment 6

[Robert Longson [:longsonr]]

Attachment: patch

Only graphic things like path, circle etc should support EventNameType_SVGGraphic

Comment 7

[Daniel Holbert [:dholbert]]

In response to the "might break something" in comment 4: I think we should just fix this.

There's a limited amount of content out there that uses SMIL, and only a fraction of that relies on SMIL-specific events (particularly considering comment 5), and only a fraction of that would hypothetically depend on this brokenness.  In any (rare) cases where content accidentally does happen to rely on this bug, it's easy enough for the author to fix it.

Comment 8

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=bac82e46e543

Comment 9

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fc83f490e0c

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8fc83f490e0c