Closed
Bug 811217
Opened 8 years ago
Closed 8 years ago
EventNameType_SMIL seems to be wrong
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: bzbarsky, Assigned: longsonr)
Details
Attachments
(1 file)
787 bytes,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
It's 0x16, whereas I'd expect 0x10... But maybe things are depending on it including the EventNameType_SVGGraphic bit (likely) and the EventNameType_XUL bit (very unlikely)?
Assignee | ||
Comment 1•8 years ago
|
||
It's just wrong. 0x10 is right. r=longsonr if you change it.
Comment 2•8 years ago
|
||
But should SVGAnimationElement support the onfoo attributes other svg elements do? I think it should, for consistency.
Assignee | ||
Comment 3•8 years ago
|
||
They need to support this: http://www.w3.org/TR/SVG/script.html#AnimationEvents
Comment 4•8 years ago
|
||
I'm just worried that since we've shipped effectively with EventNameType_SVGGraphic | EventNameType_SMIL limiting to EventNameType_SMIL might break something. What do other browsers do here?
Assignee | ||
Comment 5•8 years ago
|
||
Note that Webkit doesn't support animation events at all.
Assignee | ||
Comment 6•8 years ago
|
||
Only graphic things like path, circle etc should support EventNameType_SVGGraphic
Assignee: nobody → longsonr
Attachment #681548 -
Flags: review?(dholbert)
Updated•8 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Updated•8 years ago
|
Attachment #681548 -
Flags: review?(dholbert) → review+
Comment 7•8 years ago
|
||
In response to the "might break something" in comment 4: I think we should just fix this. There's a limited amount of content out there that uses SMIL, and only a fraction of that relies on SMIL-specific events (particularly considering comment 5), and only a fraction of that would hypothetically depend on this brokenness. In any (rare) cases where content accidentally does happen to rely on this bug, it's easy enough for the author to fix it.
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•8 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=bac82e46e543
Assignee | ||
Comment 9•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fc83f490e0c
Flags: in-testsuite-
Comment 10•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8fc83f490e0c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•