Closed
Bug 811238
Opened 12 years ago
Closed 12 years ago
Tab menu background color changes to black on gingerbread devices
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox19+ verified, firefox20 verified, fennec19+)
VERIFIED
FIXED
Firefox 20
People
(Reporter: paul.feher, Assigned: sriram)
References
Details
(Keywords: regression)
Attachments
(2 files)
1.02 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1.22 KB,
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Nightly 19.0a1 (2012-11-12) Device: Samsung Galaxy R (Android 2.3.4), HTC Desire Z (Android 2.3.3) Steps to reproduce: 1. Start firefox. 2. Open multiple tabs. 3. Open tab menu and scroll the list up and down. Expected result: For the unselected tabs the background stays grey when scrolling. Actual result: For the unselected tabs the background changes from grey to black when scrolling.The issue is only reproducible for gingerbread devices. NOTE: Please see the video. http://youtu.be/QX5WS8FGnpc
Comment 1•12 years ago
|
||
Private video; can you post a screenshot and attach it to the bug for reference. Also; is this a regression?
Updated•12 years ago
|
Keywords: regression,
regressionwindow-wanted
Updated•12 years ago
|
tracking-fennec: --- → ?
status-firefox19:
--- → affected
Same bug. ARMv6. Android 2.3.4 Last good Nightly build: http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2012-11-01-03-07-05-mozilla-central-android-armv6/ First bad Nightly build: http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2012-11-02-03-07-26-mozilla-central-android-armv6/
Comment 3•12 years ago
|
||
Over 200 changes in that range; would need Tinderbox inbound builds to narrow it down. I do see bug 783092 in that range, and if I had to guess I would put my chips on that.
Assignee: nobody → sriram
Comment 4•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5bd5bb168eb1&tochange=556b9cfb269f
Comment 5•12 years ago
|
||
I stared working on finding the regression in inbound, I will finish it first thing in the morning.
(In reply to Aaron Train [:aaronmt] from comment #3) > Over 200 changes in that range; would need Tinderbox inbound builds to > narrow it down. > > I do see bug 783092 in that range, and if I had to guess I would put my > chips on that. Looks like your guess was correct. According to tinderbox inbound builds the bug is somewhere here: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=24d449c76fe6&tochange=7599929c5258
Assignee | ||
Comment 7•12 years ago
|
||
Is the one shown in the video is a samsung device? I suspect them using a scrolling cache color as black. This should be easy to fix.
Updated•12 years ago
|
tracking-fennec: ? → 19+
Reporter | ||
Comment 8•12 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #7) > Is the one shown in the video is a samsung device? I suspect them using a > scrolling cache color as black. This should be easy to fix. Yes it is a Samsung galaxy R, but like i said on comment 0 the issue is reproducible for both Samsung galaxy R and HTC Desire Z devices.
Comment 9•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=24d449c76fe6&tochange=7599929c5258
tracking-fennec: 19+ → ?
Keywords: regressionwindow-wanted
Comment 10•12 years ago
|
||
(In reply to Andreea Pod from comment #9) > http://hg.mozilla.org/integration/mozilla-inbound/ > pushloghtml?fromchange=24d449c76fe6&tochange=7599929c5258 Why did you remove the 19+ back to question?
Comment 11•12 years ago
|
||
(In reply to Aaron Train [:aaronmt] from comment #10) > (In reply to Andreea Pod from comment #9) > > http://hg.mozilla.org/integration/mozilla-inbound/ > > pushloghtml?fromchange=24d449c76fe6&tochange=7599929c5258 > > Why did you remove the 19+ back to question? It was by mistake, sorry. Can you change it back, please, I don't have access to do that.
tracking-fennec: ? → ---
Updated•12 years ago
|
tracking-fennec: --- → 19+
tracking-firefox19:
--- → ?
Updated•12 years ago
|
Comment 12•12 years ago
|
||
sriram we're halfway into Aurora 19 cycle - can you provide an update on this bug's progress and options for fixing this regression?
Flags: needinfo?(sriram)
Assignee | ||
Comment 13•12 years ago
|
||
Done. :D
Attachment #689301 -
Flags: review?(mark.finkle)
Flags: needinfo?(sriram)
Updated•12 years ago
|
Attachment #689301 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 14•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/27c4180188af
Comment 15•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/27c4180188af
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Comment 16•12 years ago
|
||
If this landed on central a week ago then we still need mozilla-aurora approval here to get this fixed on 19 - please nominate asap with a risk assessment.
Assignee | ||
Comment 17•12 years ago
|
||
I just realized that this might affect the synced-tabs list too. Will post a patch for that.
Assignee | ||
Comment 18•12 years ago
|
||
Comment on attachment 689301 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Personas support. Bug 783092 User impact if declined: Black background for listviews in pre-honeycomb phones. Testing completed (on m-c, etc.): 12/07 Risk to taking this patch (and alternatives if risky): Very low. String or UUID changes made by this patch: None.
Attachment #689301 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #693626 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 20•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5ffc692f72
Comment 22•12 years ago
|
||
Comment on attachment 689301 [details] [diff] [review] Patch Low risk theme fix - approving for Aurora 19.
Attachment #689301 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 23•12 years ago
|
||
Comment on attachment 693626 [details] [diff] [review] Patch 2 [Approval Request Comment] Bug caused by (feature/regressing bug #): Personas User impact if declined: Synced tabs will have black background during scroll. Testing completed (on m-c, etc.): Landed yesterday. Risk to taking this patch (and alternatives if risky): Very low. String or UUID changes made by this patch: None.
Attachment #693626 -
Flags: approval-mozilla-aurora?
Comment 24•12 years ago
|
||
Comment on attachment 693626 [details] [diff] [review] Patch 2 Low risk persona's theme fix - approving for Aurora 19.
Attachment #693626 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 25•12 years ago
|
||
Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/d4777f15ba52 https://hg.mozilla.org/releases/mozilla-aurora/rev/941447ef0c00
Updated•12 years ago
|
status-firefox20:
--- → fixed
Comment 26•11 years ago
|
||
The issue is no longer reproducible on Firefox Mobile 19 beta 1 and Aurora 20.0a2 2013-01-10 on the HTC Desire Z (Android 2.3.3). Marking as verified fixed.
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•