811283 - [BB] [Dialer] Unify the mechanism to show information messages (confirm dialogs) to the user

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

The custom_dialog.js from the Shared context should not be used any longer in the Communications app. Consequently, instead of using the CustomObject object, the corresponding BB should be used, basically the Confirm one to send informative messages to the user.

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Basically, the idea is to use something similar to the deprecated custom_dialog.js but at a Communications app level dealing with the fact that in the case of the Contacts app, it may run as an iFrame of the whole Communications app or independently. The new custom_dialog.js will be at a /contacts/js level but will be linked from the main /dialer main app.

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Associated PR link: https://github.com/mozilla-b2g/gaia/pull/6404

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR diff file.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 4

[Etienne Segonzac (:etienne)]

Hi German, just commented directly on the pull request, always happy to review your code :)

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 681489 [details] [diff] [review]
Associated PR diff file.

German :etienne is ok with merging so please go ahead

Comment 6

[Etienne Segonzac (:etienne)]

FTR we still have some un-addressed comments on the PR here:
https://github.com/mozilla-b2g/gaia/pull/6404

But nothing that should block for too long :)

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

New PR, since I had some issues with the rebasing ;-999 : https://github.com/mozilla-b2g/gaia/pull/6545

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated new PR diff file.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 9

[Ismael Gonzalez [:basiclines]]

Comment on attachment 683922 [details] [diff] [review]
Associated new PR diff file.

r+ from my side for CSS and markup

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 683922 [details] [diff] [review]
Associated new PR diff file.

Hi German, please merge this once you get the r+ from :etienne.

Thanks

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 683922 [details] [diff] [review]
Associated new PR diff file.

Don't forget the bug number and r= in the commit message.

Thanks for all the hard work!

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

- PR successfully merged ;-)

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Reopened to fix some misbehavior regarding the use of element.addEventListener('click',... versus element.onclick = ... with need further investigation. For time being we are fixing this misbehavior in the particular case of the messages shown to the user in the Comms app.

Comment 14

[Germán Toro del Valle (:gtorodelvalle)]

- New PR sent: https://github.com/mozilla-b2g/gaia/pull/6557

Comment 15

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated new PR diff file.

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 684011 [details]
Associated new PR diff file.

Please merge once the you address the comments from :etienne and :jmcf

Thanks.

Comment 17

[Germán Toro del Valle (:gtorodelvalle)]

- New PR successfully landed in Gaia ;-)