All users were logged out of Bugzilla on October 13th, 2018

remove ATS-based font code

RESOLVED FIXED in mozilla19

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla19
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
As 10.5 support has been dropped, we no longer need the ATS-based version of the font management code; we use the CG-based version on 10.6 and later. So we can rip out a bunch of obsolete code here.
(Assignee)

Comment 1

6 years ago
Created attachment 681043 [details] [diff] [review]
This simply removes the ATSFontEntry class and all references to it in the Mac font code, as we never use it on 10.6+.
Attachment #681043 - Flags: review?(jdaggett)
(Assignee)

Comment 2

6 years ago
Created attachment 681044 [details] [diff] [review]
Having removed ATSFontEntry, we can then fold CGFontEntry into the MacOSFontEntry class; we no longer need the abstract superclass as we only have one concrete implementation of it.
Attachment #681044 - Flags: review?(jdaggett)
(Assignee)

Comment 3

6 years ago
Created attachment 681048 [details] [diff] [review]
part 2 - fold CGFontEntry subclass into MacOSFontEntry

Minor update - we can also drop the extra level of indirection in MakePlatformFont now that there's only one font entry class on the platform.
Attachment #681048 - Flags: review?(jdaggett)
(Assignee)

Updated

6 years ago
Attachment #681044 - Attachment is obsolete: true
Attachment #681044 - Flags: review?(jdaggett)

Updated

6 years ago
Attachment #681043 - Flags: review?(jdaggett) → review+

Updated

6 years ago
Attachment #681048 - Flags: review?(jdaggett) → review+

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/ca5d8c37113b
https://hg.mozilla.org/mozilla-central/rev/e61fdb713e40
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.