811324 - Deal with non-unique "uniqueId"s in webrtc device lists

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Since we don't get uniqueId's from Mac and Linux, and so use the deviceNames, but this means we could get non-unique id's used for the hash, and we fetch entries from the hash based on this (and so might get the wrong one).  See bug 809554

Possible solution: use the internal structure address we're associating this with as the hash/uniqueId if one isn't provided.  Note that the index is also used in some fashions, and as Tim mentions hotplugging might invalidate the indexes, so some more examination/thought is needed.

P2, if we're sure we don't get dups of deviceNames, P3

Comment 1

[Alex Chronopoulos [:achronop]]

If we are happy with Randell's proposed solution, I could create a fix that set the uniqueId by the address of the recording device structure, when it is not provided.

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

FYI, still relevant?

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I think this is still an issue given bug 1740727.