811370 - runcppunittests doesn't handle hangs gracefully

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Currently if a C++ unit test hangs, runcppunittests will throw a Python error trying to log the return code, and that's it. It should at least kill the process and log an error saying that the test timed out. Ideally it'd kill the process in such a way that we get a stack, but we don't have that functionality in mozbase yet (bug 811320).

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: runcppunittests doesn't handle hangs gracefully

Apparently I had no idea how to use mozprocess. This gets rid of a warning about using .waitForFinish and uses .run()s timeout parameter to handle timeouts properly. I tested this by adding an intentional hang to a test, and it gets reported properly:
cppunittests TEST-UNEXPECTED-FAIL | signaling_unittests | timed out after 10 seconds
make: *** [check] Error 1

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 681487 [details] [diff] [review]
runcppunittests doesn't handle hangs gracefully

Review of attachment 681487 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good

Comment 3

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c17914da5d6

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c17914da5d6