811429 - Work - filled view of Firefox Start should be scrollable with mouse wheel

Status: RESOLVED WORKSFORME

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Allison Naaktgeboren :ally]

after talking with yuan, and in the progress of adding topsites, it is clear that about:home/awesome screen should be scrollable in filled view

Comment 1

[Allison Naaktgeboren :ally]

I imagine it will qualify for mvp, as it prevents access to much of the page. sending to triage

Comment 2

[Jim Mathies [:jimm]]

Blocking, we need to test to be sure this is still broken.

Comment 3

[Matt Brubeck (:mbrubeck)]

Touch scrolling was fixed in bug 828096.

Mouse/pen scrolling for all scroll views is covered by bug 775718.

The remaining case is mouse-wheel scrolling.  I'll morph this bug to cover that, since the Firefox Start screen is a special case. (The wheel should scroll it horizontally rather than vertically, just like the Windows start screen.)

Comment 4

[Allison Naaktgeboren :ally]

As much as I love mice, this is marked p4. Asa, before I start work on it, do you still want this in v1?

Comment 5

[Asa Dotzler [:asa]]

Yes, please.

Comment 6

[Matt Brubeck (:mbrubeck)]

This would help with community testing efforts by making it easier to use Metro without touch hardware.  Marking qawanted + dogfood.

Comment 7

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

It's working great in -metrodesktop mode, but it's pretty slow scrolling in metro mode. Not sure why yet.

Comment 8

[Matt Brubeck (:mbrubeck)]

Comment on attachment 756230 [details] [diff] [review]
Patch v1

I wonder if the Metro widget pixel scroll events are off - maybe similar to bug 829952.

Comment 9

[Jim Mathies [:jimm]]

(In reply to Matt Brubeck (:mbrubeck) from comment #8)
> Comment on attachment 756230 [details] [diff] [review]
> Patch v1
> 
> I wonder if the Metro widget pixel scroll events are off - maybe similar to
> bug 829952.

I'm not sure if we send pixel scroll. Tim most of the input work in widget, cc'ing him.

Comment 10

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

We only send "line" wheel events, not "pixel" wheel events; see [2].

If we want pixel scroll, we'll have to do something similar to [1].  This should be a pretty simple change.

[1] https://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsChildView.mm?rev=53afe9fba5c0#4428
[2] https://mxr.mozilla.org/mozilla-central/source/widget/windows/winrt/MetroInput.cpp?rev=43872f1bfbda#494

Comment 11

[Rodrigo Silveira [:rsilveira] [:rodms]]

The patch I submitted is not really about filled view, I created bug 879570 for what this is actually fixing!

Opened bug 879562 about the pixel scroll mentioned on comment 10.

Comment 12

[Rodrigo Silveira [:rsilveira] [:rodms]]

The patch for Bug 879570 fixed this.