The default bug view has changed. See this FAQ.

Increase image decode chunk size

RESOLVED FIXED in mozilla19

Status

()

Core
ImageLib
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla19
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The current size 4096, using telemetry we can see that we can do about image decoding at around 10000 KB/s. This means we can do about 10240 bytes per ms. Since we have 5ms to do the decoding that means we should be able to 51200 bytes in 5ms. I'd suggest we change to 16384 as that gives a healthy margin.
(Assignee)

Comment 1

4 years ago
Created attachment 681209 [details] [diff] [review]
Increase the default to 16384

Increase this limit to 16384. Note tenfour reverted the changes in 666352 for performance reasons.
Attachment #681209 - Flags: review?(joe)
(Assignee)

Comment 2

4 years ago
Comment on attachment 681209 [details] [diff] [review]
Increase the default to 16384

(this is joe honest)
Attachment #681209 - Flags: review?(joe) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc210f0643e1
https://hg.mozilla.org/mozilla-central/rev/cc210f0643e1
Assignee: nobody → jmuizelaar
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
Does this have any impact on memory consumption?  I have no idea how many of these chunks we have live at once.
Only temporarily in the decoder. These chunks are written from data buffers we are already holding on to.
(Assignee)

Comment 7

4 years ago
(In reply to Joe Drew (:JOEDREW! \o/) from comment #6)
> Only temporarily in the decoder. These chunks are written from data buffers
> we are already holding on to.

And likely not really even in the decoder, because it doesn't make a copy of the source data.
You need to log in before you can comment on or make changes to this bug.