811469 - Indicator progress bar gradient leaks into border

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

The indicator progress bar has a 1px gradient on it (landing as part of bug 746674) to increase contrast.

Currently, that gradient leaks into the border of the progress bar. It shouldn't do that.

We likely want to specify the following rule:

background-clip: border-box, padding-box;

And then setting the background-image to:

background-image: A, B

Where A will correspond to border-box, and B to padding-box. The idea being to decouple the 1px gradient from the solid colour background.

Comment 1

[Christian Sonne [:cers]]

Attachment: Proposed patch

Hasn't been tested on Windows and Linux

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 699486 [details] [diff] [review]
Proposed patch

What's the point of clipping a "none" image at the border-box?

Comment 3

[Christian Sonne [:cers]]

(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 699486 [details] [diff] [review]
> Proposed patch
> 
> What's the point of clipping a "none" image at the border-box?

If it's not there, then the background color is clipped by the background-clip as well - which isn't intended. I made dabblet to test, but for some reason I can't get it to give a direct link to it.

Another option is to remove the background-color, and insert it as a "fake" gradient in the place where "none" currently sits, or indeed make the border opaque, but that makes it harder to change the color later.

Comment 4

[Dão Gottwald [:dao]]

Can you add a comment documenting that the border-box background-clip is there for the background-color to expand behind the border?

Comment 5

[Christian Sonne [:cers]]

Attachment: Proposed patch with note

(In reply to Dão Gottwald [:dao] from comment #4)
> Can you add a comment documenting that the border-box background-clip is
> there for the background-color to expand behind the border?

Does that look ok to you?

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 699515 [details] [diff] [review]
Proposed patch with note

Needs no extra review. Thanks!

Comment 7

[Marco Bonardo [:mak]]

if this lands today, we may hope to uplift it.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Sorry, but I had to back this out along with bug 826605 for xpcshell failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/adb13d36e50a

https://tbpl.mozilla.org/php/getParsedLog.php?id=18799534&tree=Mozilla-Inbound

TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/dom/tests/unit/test_multiple_geo_listeners.js | 2 == 1 - See following stack:
TEST-UNEXPECTED-FAIL | /Users/cltbld/talos-slave/test/build/xpcshell/tests/dom/tests/unit/test_multiple_geo_listeners.js | 420 == 42 - See following stack:

Comment 9

[Marco Bonardo [:mak]]

relanded, this css-only change cannot cause an xpcshell test failure
https://hg.mozilla.org/integration/mozilla-inbound/rev/762779b020db

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 699515 [details] [diff] [review]
Proposed patch with note

[Approval Request Comment]
Bug caused by (feature/regressing bug #): downloads panel feature
User impact if declined: theme polish glitch
Testing completed (on m-c, etc.): m-i (merge pending)
Risk to taking this patch (and alternatives if risky): polish style fix, feature only
String or UUID changes made by this patch: none

Comment 11

[Marco Bonardo [:mak]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8233d14cdc57

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/762779b020db

Comment 13

[Gabriela [:gaby2300]]

Verified fixed using latest beta and Windows 7 64 bit.

Comment 14

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 20 RC: - there is no leaking into the border caused by the Indicator progress. 

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.8:
Build ID: 20130326150557

Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0