Closed Bug 811630 Opened 12 years ago Closed 12 years ago

Bugzilla::Attachment->new() queries the database multiple times for the same information when displaying a bug

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 811280

People

(Reporter: glob, Assigned: glob)

References

Details

(Keywords: perf)

Attachments

(1 file)

patch v1
816 bytes, patch
Details | Diff | Splinter Review 
Bugzilla::Attachment->new() is called multiple times when displaying a bug.
each call results in a round trip to the database to fetch the bug's row.
this is inefficient.

it's loading once for the attachment table, and then once every time it's mentioned in a comment (minimum of two loads per bug view).  extensions which work with attachments (eg splinter) increase the load count.
See Also: → 811280
Attached patch patch v1 — — Splinter Review 

        Attachment #681361 -
        Flags: review?(dkl)

    
  
See Also:  → 811650

    
  
Severity: major → normal

    
    

    
  
Comment on attachment 681361 [details] [diff] [review]
patch v1

hold off on this review for now

        Attachment #681361 -
        Flags: review?(dkl)

    
    

    
  
this has been fixed in a more generic way on bug 811280
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: