811650 - Bugzilla::Classification->new() queries the database multiple times for the same information when displaying a bug

Status: RESOLVED DUPLICATE of bug 811280

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

Bugzilla::Classification->new() is called multiple times when displaying a bug.
each call results in a round trip to the database to fetch the classifications's row.
this is inefficient.

this happens because we iterate over each product's classification, and each product creates their own unique instance of a classification object.

we should use the request cache and share a single classification object between products from the same classification.

Comment 1

[:glob ✱]

Attachment: patch v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 681396 [details] [diff] [review]
patch v1

Review of attachment 681396 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine and works as expected. r=dkl

Comment 3

[:glob ✱]

hold off on approval for this; i'm playing around with a more generic approach to caching of objects for bug 811280, which i may reuse here.

Comment 4

[:glob ✱]

this has been fixed in a more generic way on bug 811280