Closed
Bug 811678
Opened 12 years ago
Closed 12 years ago
Decide what is happening to "About Your Rights"
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Firefox OS Graveyard
Gaia::Settings
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: gerv, Assigned: gerv)
Details
(Keywords: l12y)
Attachments
(2 files, 2 obsolete files)
7.60 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
355 bytes,
text/html
|
Details |
We need to figure out the function of the "About Your Rights" option in Settings | Device Information. It currently contains content from Firefox which does not read correctly for Firefox OS. I think we have two choices: 1) Provide a user-friendly summary of the legal parameters surrounding Firefox OS, i.e. convert the page to apply to Firefox OS 2) Remove it entirely I am in favour of doing 1), but I suspect we will need to write the copy very quickly. See also bug 811677, which is about rejigging the options on that screen. Gerv
Assignee | ||
Comment 1•12 years ago
|
||
The current text is here: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties It is: "About Your Rights Mozilla Firefox is free and open source software, built by a community of thousands from all over the world. There are a few things you should know: Firefox is made available to you under the terms of the Mozilla Public License. This means you may use, copy and distribute Firefox to others. You are also welcome to modify the source code of Firefox as you want to meet your needs. The Mozilla Public License also gives you the right to distribute your modified versions. You are not granted any trademark rights or licenses to the trademarks of the Mozilla Foundation or any party, including without Temporary Text limitation the Firefox name or logo. Additional information on trademarks may be found only here. Some features in Firefox, such as the Crash Reporter, give you the option to provide feedback to Mozilla. By choosing to submit feedback, you give Mozilla permission to use the feedback to improve its products, to publish the feedback on its websites, and to distribute the feedback." Questions arising: * What do we want to say? * Does Firefox OS even have a Crash Reporter? Gerv
Assignee | ||
Comment 2•12 years ago
|
||
More questions. If we said: "Firefox OS is made available to you under the terms of the Mozilla Public License." would that be true? What's the current legal situation about how the builds which OEMs ship on their phones are licensed to the users? Should we instead talk about our builds of Firefox OS in general rather than the one they have on their phone? "You are not granted any trademark rights or licenses to the trademarks of the Mozilla Foundation or any party, including without Text limitation the Firefox name or logo. Additional information on trademarks may be found here." Do we need to have some more stuff about trademarks somewhere, perhaps in the Legal Information section? "Some features in Firefox, such as the Crash Reporter, give you the option to provide feedback to Mozilla. By choosing to submit feedback, you give Mozilla permission to use the feedback to improve its products, to publish the feedback on its websites, and to distribute the feedback." Does this fit with the current privacy information? Gerv
Comment 3•12 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #1) > * Does Firefox OS even have a Crash Reporter? > Firefox OS has a crash reporter.
Assignee | ||
Updated•12 years ago
|
Flags: needinfo?(jmenon)
Comment 4•12 years ago
|
||
Hi Gerv, This looks like default copy from Firefox and isn't applicable to FFOS. You're right, FFOS isn't all under the MPL - Gonk and low level drivers are either other OS licenses or proprietary. How about this: "Firefox OS is built on free and open source software by a community of thousands from all over the world. There are a few things you should know: Firefox OS is made available to you under the terms of several open source licenses including the Mozilla Public License. A device running Firefox OS may also contain proprietary software from third parties. Any code provided under open licenses give you the right to modify the source code and distribute your modified versions as long as you comply with their terms. You are not granted any trademark rights or licenses to the trademarks of the Mozilla Foundation or any party, including without Temporary Text limitation the Firefox name or logo. Additional information on trademarks may be found only here. Some features in Firefox OS, such as the Crash Reporter, give you the option to provide feedback to Mozilla. By choosing to submit feedback, you give Mozilla permission to use the feedback to improve its products, to publish the feedback on its websites, and to distribute the feedback." What do you think Gerv?
Flags: needinfo?(jmenon) → needinfo?(gerv)
Comment 5•12 years ago
|
||
Hi Gerv, This looks like default copy from Firefox and isn't applicable to FFOS. You're right, FFOS isn't all under the MPL - Gonk and low level drivers are either other OS licenses or proprietary. How about this: "Firefox OS is built on free and open source software by a community of thousands from all over the world. There are a few things you should know: Firefox OS is made available to you under the terms of several open source licenses including the Mozilla Public License. A device running Firefox OS may also contain proprietary software from third parties. Any code provided under open licenses give you the right to modify the source code and distribute your modified versions as long as you comply with their terms. You are not granted any trademark rights or licenses to the trademarks of the Mozilla Foundation or any party, including without Temporary Text limitation the Firefox name or logo. Additional information on trademarks may be found only here. Some features in Firefox OS, such as the Crash Reporter, give you the option to provide feedback to Mozilla. By choosing to submit feedback, you give Mozilla permission to use the feedback to improve its products, to publish the feedback on its websites, and to distribute the feedback." What do you think Gerv?
Assignee | ||
Comment 6•12 years ago
|
||
Great, apart from the trademark para, which has some stray words in (also in the original). It should read simply: "You are not granted any trademark rights or licenses to the trademarks of the Mozilla Foundation or any party, including without limitation the Firefox name or logo." Gerv
Flags: needinfo?(gerv)
Assignee | ||
Comment 7•12 years ago
|
||
Comment 8•12 years ago
|
||
Comment on attachment 682415 [details] [diff] [review] Patch v.1 Stas, do we need to change the ids?
Attachment #682415 -
Flags: review?(21) → review?(stas)
Comment 9•12 years ago
|
||
Comment on attachment 682415 [details] [diff] [review] Patch v.1 Yes, we need to change the ids. I'm afraid we'll end up with something like about-your-rights2-0, or maybe about-your-rights-b2g-0? Also, gerv, when bug 812977 lands this patch will bit-rot, but it should be easy to update it. Thanks!
Attachment #682415 -
Flags: review?(stas) → review-
Assignee | ||
Comment 10•12 years ago
|
||
stas: should I wait until 812977 lands before updating it? Gerv
Comment 11•12 years ago
|
||
I think that might be the easiest way to go. I hope to have it landed this evening.
Comment 12•12 years ago
|
||
...and it just landed :)
Assignee | ||
Comment 13•12 years ago
|
||
Here's an unbitrotted patch, with renamed IDs. Gerv
Attachment #682415 -
Attachment is obsolete: true
Attachment #683646 -
Flags: review?(stas)
Attachment #683646 -
Flags: review?(21)
Comment 14•12 years ago
|
||
(In reply to Gervase Markham [:gerv] from comment #13) > Created attachment 683646 [details] [diff] [review] > Patch v.2 > > Here's an unbitrotted patch, with renamed IDs. > > Gerv You may need to change the IDs in the code too.
Assignee | ||
Comment 15•12 years ago
|
||
Oh, smeg, of course. Hang on... Gerv
Assignee | ||
Comment 16•12 years ago
|
||
Attachment #683692 -
Flags: review?(stas)
Assignee | ||
Updated•12 years ago
|
Attachment #683692 -
Flags: review?(21)
Assignee | ||
Updated•12 years ago
|
Attachment #683646 -
Attachment is obsolete: true
Attachment #683646 -
Flags: review?(stas)
Attachment #683646 -
Flags: review?(21)
Attachment #683692 -
Flags: review?(stas)
Attachment #683692 -
Flags: review?(21)
Attachment #683692 -
Flags: review+
Comment 17•12 years ago
|
||
Sounds good to me. If you made a pull request and push the link here I can merge it. (Or you can merge if you have the credentials to do so).
Assignee | ||
Comment 18•12 years ago
|
||
I'm not immediately set up to make a pull request (my gaia is not a fork), nor do I have credentials to merge directly. Could you sort it out? 9pm here... Thanks :-) Gerv
Comment 19•12 years ago
|
||
Pointer to Github pull-request
Comment 20•12 years ago
|
||
Thanks, Gerv, for the patch! I carried over Vivien's review to the pull request and took comment 17 as his approval to merge it. https://github.com/mozilla-b2g/gaia/commit/1af171ca9726dae10103eff70bbf2b4a7a0aba60
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 21•11 years ago
|
||
Verified fixed in 2013-02-04-12-36-26 pvt nightly b2g18 build
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•