B2G RIL: clean up ril_worker

NEW
Unassigned

Status

Firefox OS
RIL
5 years ago
3 years ago

People

(Reporter: vicamo, Unassigned)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [grooming])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
ril_worker.js is now 7000+ lines of code. After bug 798491 landed, we should now split it into several smaller scripts. For example:

  === In ril_worker_icc.js ===
  this.ICC = {
    // All ICC related stuff
  };
  // ICC-specific parcel handlers
  this.ICC[REQUEST_SIM_IO] = function REQUEST_SIM_IO(length, options) {
  }
  // Allow this file to be imported via Components.utils.import().
  this.EXPORTED_SYMBOLS = Object.keys(this);

  === In ril_worker.js ===
  importScripts("ril_consts.js", "systemlibs.js", "ril_worker_icc.js");
  ...
  RIL[REQUEST_SIM_IO] = ICC[REQUEST_SIM_IO].bind(ICC);
(Reporter)

Comment 1

5 years ago
Created attachment 681612 [details] [diff] [review]
Part 1: Clean up ICC functions - WIP

TODO: fix test scripts
(Reporter)

Comment 2

5 years ago
Created attachment 681614 [details] [diff] [review]
Part 2: Clean up SMS functions

TODO: fix test cases
Depends on: 816893
(Reporter)

Updated

4 years ago
Depends on: 905109
(Reporter)

Updated

4 years ago
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Depends on: 928773

Comment 3

4 years ago
Move it to backlog.
blocking-b2g: --- → backlog

Updated

3 years ago
Depends on: 964644
Whiteboard: [grooming]

Updated

3 years ago
See Also: → bug 1123066

Updated

3 years ago
Depends on: 1123201
(Assignee)

Updated

3 years ago
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
Depends on: 1146799
No longer depends on: 1146799

Updated

3 years ago
Depends on: 1159591

Updated

3 years ago

Updated

3 years ago
Depends on: 1146799

Updated

3 years ago
Depends on: 999300
You need to log in before you can comment on or make changes to this bug.